Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Store custom presets in browser local cache #4427

Closed
olganaz opened this issue Apr 5, 2024 · 1 comment · Fixed by #4512
Closed

Macro: Store custom presets in browser local cache #4427

olganaz opened this issue Apr 5, 2024 · 1 comment · Fixed by #4512
Assignees
@ilya-asiyuk-epam
Labels
draft feature request IDT Bucket: IDT related issues Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.22.0-rc.2

Comments

@olganaz
Copy link
Collaborator

olganaz commented Apr 5, 2024 •
edited by vanoprenko
Loading

Custom presets should be stored in browser's local cache and restored in the monomer library on Ketcher restart.

In case certain preset loaded from the cache conflicts with another preset loaded from the library (has the same name), its name should be modified by adding "_Copy" to the end. The new name should be validated again and if still not unique, yet another postfix to be added, etc. Preset with updated name should replace the original one in browser cache.
@olganaz olganaz added draft feature request IDT Bucket: IDT related issues labels Apr 5, 2024
@olganaz olganaz added this to the Ketcher 2.23.0-rc.1 milestone Apr 5, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam self-assigned this Apr 18, 2024
ilya-asiyuk-epam added a commit that referenced this issue Apr 22, 2024
@ilya-asiyuk-epam
#4427 - Macro: Store custom presets in browser local cache
df85ab2
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Apr 22, 2024 that will close this issue
#4427 - Macro: Store custom presets in browser local cache #4512
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Apr 23, 2024
@ilya-asiyuk-epam
#4427 - Macro: Store custom presets in browser local cache
192fc4c
ilya-asiyuk-epam added a commit that referenced this issue Apr 23, 2024
@ilya-asiyuk-epam
#4427 - Macro: Store custom presets in browser local cache
1d71439
ilya-asiyuk-epam added a commit that referenced this issue Apr 23, 2024
@ilya-asiyuk-epam
#4427 - Macro: Store custom presets in browser local cache
2a39c23
ilya-asiyuk-epam added a commit that referenced this issue Apr 24, 2024
@ilya-asiyuk-epam
#4427 - Macro: Store custom presets in browser local cache
cf556d9
ilya-asiyuk-epam added a commit that referenced this issue Apr 24, 2024
@ilya-asiyuk-epam
#4427 - Macro: Store custom presets in browser local cache
a66c653
ilya-asiyuk-epam added a commit that referenced this issue Apr 24, 2024
@ilya-asiyuk-epam
Merge pull request #4512 from epam/4427-macro-store-custom-presets-in…
da48833 
…-browser-local-cache

#4427 - Macro: Store custom presets in browser local cache
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label May 13, 2024
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Indigo Toolkit Version 1.20.0-dev.1.32-gf28bad61-wasm32-wasm-clang-12.0.0
  • Ketcher Version 2.21.0-rc.2 Build at 2024-05-13; 05:32:02
  • Chrome Version 124.0.6367.201 (Official Build) (64-bit)
  • Windows 10

@split-ends split-ends mentioned this issue Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
draft feature request IDT Bucket: IDT related issues Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.22.0-rc.2
Development

Successfully merging a pull request may close this issue.

#4427 - Macro: Store custom presets in browser local cache epam/ketcher
4 participants
@rrodionov91 @AlexeyGirin @olganaz @ilya-asiyuk-epam