Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When merging two cyclic sequences in the Sequence mode, they disappear from the canvas #4708

Closed
ViktoriaTkacheva opened this issue May 29, 2024 · 3 comments · Fixed by #4703 or #4770
Closed
Assignees
Labels

Comments

@ViktoriaTkacheva
Copy link
Collaborator

ViktoriaTkacheva commented May 29, 2024

Steps to Reproduce

  1. Switch to the Macro mode

  2. Draw two cyclic sequences, consisting of any 4 nucleotides, for example:

    image
  3. Switch to the Sequence mode – the Text-editing mode

    image
  4. Try to merge these two sequences

    image
  5. Switch to the Flex mode and move all nucleotides apart from each other so that all bonds are visible

Actual behavior
In the Sequence mode, the cyclic sequences disappear from the canvas. But in the Flex mode, a new bond between two cyclic sequences is displayed, although there are no free APs in these two sequences

image image image

Expected behavior
If the nucleotides on the ends of sequences do not have a free AP R1 or R2 at the place, where they merge, an error message appears on the canvas

Error Message:
It is impossible to merge fragments. Attachment point to establish bonds are not available.

Screenshots

2024-05-29_10h40_38.mp4

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome
  • Version: (125.0.6422.113) x64

Ketcher version 2.21.0-rc.2, Build at 2024-05-28; 14:29:04

Can be related #4548, #4706

@NadezhdaPeskun
Copy link

NadezhdaPeskun commented Jun 3, 2024

Should be verified with next Issues: (#4708, #4575, #4506, #4706) + #4328
Error Message should appear:
Error Message:
It is impossible to merge fragments. Attachment point to establish bonds are not available.

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 4, 2024

Not fixed.
Both sequences simply disappears from the canvas.

  1. Switch to Macro
  2. Load from file: two cycles.zip
  3. Go to Sequence mode
  4. Edit top sequence
  5. Put cursor at the end of the line
  6. Press Del button

Actual behavior:
Both sequences simply disappears from the canvas.
image

Expected behavior:
Error message appears: It is impossible to merge fragments. Attachment point to establish bonds are not available.
336392272-ec0c2702-a8b7-422f-bc5b-f01640771873

2024-06-04_12h47_43.mp4

@AlexeyGirin AlexeyGirin reopened this Jun 4, 2024
@svvald svvald linked a pull request Jun 6, 2024 that will close this issue
9 tasks
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.3 Build at 2024-06-10; 12:34:49
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment