Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Edit Connection Points dialog via right click on bond #4905

Closed
ljubica-milovic opened this issue Jun 26, 2024 · 2 comments · Fixed by #5189
Closed

Open Edit Connection Points dialog via right click on bond #4905

ljubica-milovic opened this issue Jun 26, 2024 · 2 comments · Fixed by #5189
Assignees
@rrodionov91
Labels
feature request Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.24.0-rc.1

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jun 26, 2024 •
edited
Loading

Background
Currently if the user wants to change connection points that participate in a bond, they would have to delete that bond, and establish a new one.
This feature would allow the user to change connection points more easily and provide bond details in a user-friendly way.
.
.
Requirements

  1. When the user right clicks on a bond, the context menu with "Edit Connection Points..." option should appear.
    .
    .
  2. Clicking on the "Edit Connection Points..." option opens the "Edit Connection Points" dialog.
    .....2.1. That dialog is identical to the "Select Connection points" dialog, just with a different title, and a different button label ("Reconnect" instead of "Connect")
    ..........2.1.1. The dialog contains appropriately marked connection points: gray if they participate in other bonds, white if they participate in no bonds, and teal if they participate in this bond (just like "Select Connection points" dialog).
    (Image for better understanding)
    image
    ..........2.1.2. The user is able to interact teal and white attachment points (just like "Select Connection points" dialog).
    .....2.2. If there are no available (white) connection points on both monomers, button "Reconnect" should be disabled.
    .
    .
  3. The user can change the attachment points that participate in the selected bond.
    .....3.1. Clicking "Reconnect" in the dialog (if different attachment points were chosen) results in deletion of the previous bond and establishment of the new one (with new attachment points).
    .....3.2. Clicking "Reconnect" in the dialog (if different attachment points were not chosen) results in no change of connection points of the bond.
    .....3.3. Clicking "Cancel" in the dialog results in no change of connection points of the bond.
@ljubica-milovic ljubica-milovic added this to the Ketcher 2.24.0-rc.1 milestone Jun 26, 2024
@ljubica-milovic ljubica-milovic changed the title Add preview while establishing a bond Open Edit Connection Points dialog via right click on bond Jul 9, 2024
@Zhirnoff Zhirnoff added the Test Cases Written Test cases has been written for that issue label Jul 23, 2024
@Zhirnoff
Copy link
Collaborator

Tests added to the automation table.

@rrodionov91 rrodionov91 self-assigned this Jul 29, 2024
rrodionov91 added a commit that referenced this issue Jul 29, 2024
@rrodionov91
#4905 - Open Edit Connection Points dialog via right click on bond
db6840d 
- refactored context menu for macromolecules
- added context menu for polymer bond
- added reconnecting logic
@rrodionov91 rrodionov91 linked a pull request Jul 29, 2024 that will close this issue
#4905 - Open Edit Connection Points dialog via right click on bond #5189
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 30, 2024
@rrodionov91
#4905 - Open Edit Connection Points dialog via right click on bond
3a50bf8 
- refactored context menu for macromolecules
- added context menu for polymer bond
- added reconnecting logic
rrodionov91 added a commit that referenced this issue Jul 31, 2024
@rrodionov91
#4905 - Open Edit Connection Points dialog via right click on bond (#…
84bae80 
…5189)

- refactored context menu for macromolecules
- added context menu for polymer bond
- added reconnecting logic
This was referenced Aug 1, 2024
Open
Closed
Closed
Closed
Open
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Aug 7, 2024

Tested. We have 5 bugs connected to ticket.
2024-08-07_11h35_37
2024-08-07_11h35_52

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.24.0-rc.1]
Indigo version
[Version 1.23.0-rc.1]

@Zhirnoff Zhirnoff mentioned this issue Aug 14, 2024
Closed
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
#4905 - Open Edit Connection Points dialog via right click on bond (#…
b4a9cc3 
…5189)

- refactored context menu for macromolecules
- added context menu for polymer bond
- added reconnecting logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
feature request Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.24.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4905 - Open Edit Connection Points dialog via right click on bond epam/ketcher
3 participants
@rrodionov91 @Zhirnoff @ljubica-milovic