Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled query features in extended table not disabled in right-click menu #4957

Closed
Zhirnoff opened this issue Jul 2, 2024 · 2 comments · Fixed by #5159
Closed

Disabled query features in extended table not disabled in right-click menu #4957

Zhirnoff opened this issue Jul 2, 2024 · 2 comments · Fixed by #5159

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jul 2, 2024

Steps to Reproduce

  1. Disable some query feature via Console ( for example ketcher.setSettings({ disableQueryElements: ['Pol', 'MH', 'AH'], })

2024-07-08_15h18_43
2. Add Benzene ring on canvas
3. Click on atom of Benzene ring by right-click -> Edit...
4. Set Atom Type to Special
5. Type any disabled element from Extended table into Special field

Actual behavior
Disabled query features in extended table not disabled in right-click menu. If user have Atom Type set to 'Special' and they enter disabled element in the 'Special' field, Ketcher allow to apply this change.
2024-07-08_15h40_39

Expected behavior
Disabled query features in Extended table should also be disabled in the right-click menu. If user have Atom Type set to 'Special' and they enter disabled element in the 'Special' field, Ketcher doesn't allow to apply this change.
2024-07-08_15h41_14

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.7]
Indigo version
[Version 1.21.0-rc.2]

#187864458

@Zhirnoff Zhirnoff added this to the Ketcher 2.24.0-rc.1 milestone Jul 2, 2024
@tmrr13 tmrr13 self-assigned this Jul 17, 2024
beisenova-aliya added a commit that referenced this issue Jul 24, 2024
svvald pushed a commit that referenced this issue Jul 26, 2024
…t-click menu (#5159)

* #4957 - disable query features in extended table and add validation to field pseudo

* #4957-fix type of disableQueryElements in args

* #4957-update autotests

* #4957-fix tests which expected to fail but passed
@AlexeyGirin
Copy link
Collaborator

Fixed.
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-31; 05:31:01
  • Indigo Toolkit Version 1.23.0-dev.2.1-gd93b8ec4-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Aug 7, 2024

Tested. Bug fixed.
2024-08-07_14h05_05
2024-08-07_14h05_16
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.24.0-rc.1]
Indigo version
[Version 1.23.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment