Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bond tool and Erase tool buttons have to be disabled in Sequeince mode (since they are not applicable) #4962

Closed
AlexeyGirin opened this issue Jul 2, 2024 · 1 comment · Fixed by #5020
Closed

Bond tool and Erase tool buttons have to be disabled in Sequeince mode (since they are not applicable) #4962

AlexeyGirin opened this issue Jul 2, 2024 · 1 comment · Fixed by #5020
Assignees
@Guch1g0v
Labels
bug Priority: Low Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.24.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jul 2, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode

Actual behavior
Bond tool and Erase tool buttons are enabled but do nothing (since they are not applicable)
image

Expected behavior
Bond tool and Erase tool buttons are disabled
image

Versions

  • Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 08:57:41
  • Indigo Toolkit Version 1.22.0-rc.1.0-g2bef0ce6c-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

KUDOS to @ljubica-milovic who found that issue
@AlexeyGirin AlexeyGirin added bug Sequence mode Bucket: Sequence mode related issues labels Jul 2, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.24.0-rc.1 milestone Jul 2, 2024
@Guch1g0v Guch1g0v self-assigned this Jul 4, 2024
Guch1g0v added a commit that referenced this issue Jul 5, 2024
@Guch1g0v
#4962 - Bond tool and Erase tool buttons have to be disabled in Seque…
7297424 
…ince mode (since they are not applicable)
@Guch1g0v Guch1g0v linked a pull request Jul 5, 2024 that will close this issue
#4962 - Bond tool and Erase tool buttons have to be disabled in Sequeince mode (since they are not applicable) #5020
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jul 7, 2024
@Guch1g0v
#4962 - Bond tool and Erase tool buttons have to be disabled in Seque…
9d1b508 
…ince mode (since they are not applicable) (#5020)
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-25; 05:30:25
  • Indigo Toolkit Version 1.23.0-dev.1.14-g284c33a1-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.73 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
bug Priority: Low Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.24.0-rc.1
2 participants
@AlexeyGirin @Guch1g0v