Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection is displayed at the bottom of the row, if drag a horizontal side-chain connection between the extreme nucleotides of a row #4975

Closed
ViktoriaTkacheva opened this issue Jul 3, 2024 · 0 comments · Fixed by #5027 or #5072
Closed

Connection is displayed at the bottom of the row, if drag a horizontal side-chain connection between the extreme nucleotides of a row #4975

ViktoriaTkacheva opened this issue Jul 3, 2024 · 0 comments · Fixed by #5027 or #5072
Assignees
@rrodionov91
Labels
bug Priority: Medium Snake mode Bucket: Snake mode related issues
Milestone
Ketcher 2.23.0-rc.2

Comments

@ViktoriaTkacheva
Copy link
Collaborator

Steps to Reproduce

  1. Switch to the Macro mode – the Snake mode
  2. Open this file long nucleotides 4R.zip
  3. Drag a horizontal side-chain connection between the extreme nucleotides of a row

Actual behavior
A horizontal side-chain connection is displayed at the bottom of the row

image

Expected behavior
A horizontal side-chain connection is displayed above the row

image

Screenshots

2024-07-03_15h06_44.mp4

As per requirements:

  1. If two monomers linked by side-chain connection are positioned in the same row of monomers, the connection should be drawn horizontally above these monomers.

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome
  • Version: (126.0.6478.127) x64

Ketcher version 2.23.0-rc.1, Build at 2024-07-02; 09:03:38

Issue found while testing #3532
@ViktoriaTkacheva ViktoriaTkacheva added this to the Ketcher 2.23.0-rc.2 milestone Jul 3, 2024
@rrodionov91 rrodionov91 self-assigned this Jul 6, 2024
rrodionov91 added a commit that referenced this issue Jul 7, 2024
@rrodionov91
#4975 - Displaying side chain connections in snake-like mode
8d772cc 
- fixed matrix cells amount calculation
- fixed matrix recalculation during undo/redo
@rrodionov91 rrodionov91 linked a pull request Jul 7, 2024 that will close this issue
#4975 - Connection is displayed at the bottom of the row, if drag a horizontal side-chain connection between the extreme nucleotides of a row #5027
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 8, 2024
@rrodionov91
#4975 - Displaying side chain connections in snake-like mode
d9f98ba 
- fixed matrix cells amount calculation
- fixed matrix recalculation during undo/redo
rrodionov91 added a commit that referenced this issue Jul 10, 2024
@rrodionov91
#4975 - Connection is displayed at the bottom of the row, if drag a h…
f5cce35 
…orizontal side-chain connection between the extreme nucleotides of a row (#5027)

- fixed matrix cells amount calculation
- fixed matrix recalculation during undo/redo
- link monomer to matrix cell instead of node
- fixed rna bases connections
rrodionov91 added a commit that referenced this issue Jul 10, 2024
@rrodionov91
#4975 - Displaying side chain connections in snake-like mode
9715553 
- fixed matrix cells amount calculation
- fixed matrix recalculation during undo/redo
@rrodionov91 rrodionov91 linked a pull request Jul 10, 2024 that will close this issue
Backmerge: #4975 - Connection is displayed at the bottom of the row, if drag a horizontal side-chain connection between the extreme nucleotides of a row #5072
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 11, 2024
@rrodionov91
Backmerge: #4975 - Connection is displayed at the bottom of the row, …
2c9909d 
…if drag a horizontal side-chain connection between the extreme nucleotides of a row (#5072)

- fixed matrix cells amount calculation
- fixed matrix recalculation during undo/redo
- link monomer to matrix cell instead of node
- fixed rna bases connections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: Medium Snake mode Bucket: Snake mode related issues
Projects
None yet
Milestone
Ketcher 2.23.0-rc.2
3 participants
@rrodionov91 @Zhirnoff @ViktoriaTkacheva