Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The second of three horizontal bond overlaps backbone connection line #4997

Open
AlexeyGirin opened this issue Jul 4, 2024 · 2 comments · Fixed by #5028 or #5037
Open

The second of three horizontal bond overlaps backbone connection line #4997

AlexeyGirin opened this issue Jul 4, 2024 · 2 comments · Fixed by #5028 or #5037
Labels
bug Priority: Low Snake mode Bucket: Snake mode related issues
Milestone
Refined Backlog

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jul 4, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macromolecules mode - Snake mode
  2. Load from file: The second of three horizontal bond overlaps backbone connection line.zip

Actual behavior
The bottom horizontal bonds does not shift if there is an overlap
image

Expected behavior
No overlapping happens

Versions

  • Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 08:57:41
  • Indigo Toolkit Version 1.22.0-rc.1.0-g2bef0ce6c-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - #3532
@AlexeyGirin AlexeyGirin added bug Priority: Low Flex mode Bucket: Flex canvas related mode labels Jul 4, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.2 milestone Jul 4, 2024
@AlexeyGirin AlexeyGirin added Snake mode Bucket: Snake mode related issues and removed Snake mode Bucket: Snake mode related issues Flex mode Bucket: Flex canvas related mode labels Jul 5, 2024
@rrodionov91 rrodionov91 self-assigned this Jul 7, 2024
rrodionov91 added a commit that referenced this issue Jul 7, 2024
@rrodionov91
#4997 - The second of three horizontal bond overlaps backbone connect…
8d7d36a 
…ion line

- changed order of rendering bonds(side over backbone)

#4995 - The bottom horizontal bonds does not shift if there is an overlap

- applied offsets for bottom part of horizontal bonds
@rrodionov91 rrodionov91 linked a pull request Jul 7, 2024 that will close this issue
#4997 - The second of three horizontal bond overlaps backbone connection line #5028
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 8, 2024
@rrodionov91
#4997 - The second of three horizontal bond overlaps backbone connect…
ed5ad1f 
…ion line (#5028)

#4997 - The second of three horizontal bond overlaps backbone connection line

- changed order of rendering bonds(side over backbone)

#4995 - The bottom horizontal bonds does not shift if there is an overlap

- applied offsets for bottom part of horizontal bonds
- updated tests/screenshots
- fixed bond color in flex mode
rrodionov91 added a commit that referenced this issue Jul 8, 2024
@rrodionov91
#4997 - The second of three horizontal bond overlaps backbone connect…
79d60fa 
…ion line

- changed order of rendering bonds(side over backbone)

#4995 - The bottom horizontal bonds does not shift if there is an overlap

- applied offsets for bottom part of horizontal bonds
@rrodionov91 rrodionov91 linked a pull request Jul 8, 2024 that will close this issue
Backmerge: #4997 - The second of three horizontal bond overlaps backbone connection line #5037
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 8, 2024
@rrodionov91
Backmerge: #4997 - The second of three horizontal bond overlaps backb…
677beee 
…one connection line (#5037)

* #4997 - The second of three horizontal bond overlaps backbone connection line

- changed order of rendering bonds(side over backbone)

#4995 - The bottom horizontal bonds does not shift if there is an overlap

- applied offsets for bottom part of horizontal bonds
- updated screenshots
@AnnaKosol
Copy link
Contributor

Issue is reproduced
Image
Versions:
Ketcher Version 2.23.0-rc.2 Build at 2024-07-10; 19:39:22
Indigo Version 1.22.0-rc.2.0-ga21fb5d8f-wasm32-wasm-clang-19.0.0
Chrome Версия 126.0.6478.127 (Официальная сборка), (arm64)
MacOs Sonoma 14.5

@AnnaKosol AnnaKosol reopened this Jul 11, 2024
@rrodionov91
Copy link
Collaborator

Implemented side connection overlapping over the backbone connection as on screenshot above from @AnnaKosol
Shifting lines to prevent overlapping at all is postponed for now.
Moving to refined backlog.

@rrodionov91 rrodionov91 removed their assignment Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Priority: Low Snake mode Bucket: Snake mode related issues
Projects
None yet
Milestone
Refined Backlog
3 participants
@rrodionov91 @AlexeyGirin @AnnaKosol