Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When dragging the side chain connections between CHEM, all these connections pass exclusively from the left, and not the shortest path #5034

Closed
ViktoriaTkacheva opened this issue Jul 8, 2024 · 1 comment · Fixed by #5027 or #5072
Closed

When dragging the side chain connections between CHEM, all these connections pass exclusively from the left, and not the shortest path #5034

ViktoriaTkacheva opened this issue Jul 8, 2024 · 1 comment · Fixed by #5027 or #5072
Assignees
@rrodionov91
Labels
bug Priority: Medium Snake mode Bucket: Snake mode related issues
Milestone
Ketcher 2.23.0-rc.2

Comments

@ViktoriaTkacheva
Copy link
Collaborator

Case 1: The vertical side chain connections

Steps to Reproduce

  1. Switch to the Macro mode – the Snake mode
  2. Open this file CHEM many APs.zip
  3. Drag several vertical side-chain connections

Case 2: The horizontal side chain connections

Steps to Reproduce

  1. Switch to the Macro mode – the Snake mode
  2. Open this file CHEM many APs.zip
  3. Drag several horizontal side-chain connections

Actual behavior
All these side-chain connections pass exclusively from the left, and not the shortest path

image image

Expected behavior
The vertical and horizontal side-chain connections pass by the shortest path when possible. The horizontal connections should be drawn horizontally above the monomers

Screenshots

2024-07-05_17h08_55.mp4
2024-07-05_17h12_01.mp4

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome
  • Version: (126.0.6478.127) x64

Ketcher version 2.23.0-rc.1, Build at 2024-07-02; 09:03:38

Issue found while testing #3532
@ViktoriaTkacheva ViktoriaTkacheva added bug Priority: Medium Snake mode Bucket: Snake mode related issues labels Jul 8, 2024
@ViktoriaTkacheva ViktoriaTkacheva added this to the Ketcher 2.23.0-rc.2 milestone Jul 8, 2024
This was linked to pull requests Jul 8, 2024
#4975 - Connection is displayed at the bottom of the row, if drag a horizontal side-chain connection between the extreme nucleotides of a row #5027
Merged
Backmerge: #4975 - Connection is displayed at the bottom of the row, if drag a horizontal side-chain connection between the extreme nucleotides of a row #5072
Merged
@rrodionov91 rrodionov91 self-assigned this Jul 11, 2024
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.
2024-07-11_17h41_40

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.2]
Indigo version
[Version 1.22.0-rc.2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: Medium Snake mode Bucket: Snake mode related issues
Projects
None yet
Milestone
Ketcher 2.23.0-rc.2
3 participants
@rrodionov91 @Zhirnoff @ViktoriaTkacheva