Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is not possible to enter a value when selecting cm, inch, pt manually in the Settings #5201

Closed
AnnaKosol opened this issue Aug 1, 2024 · 1 comment · Fixed by #5336
Closed

It is not possible to enter a value when selecting cm, inch, pt manually in the Settings #5201

AnnaKosol opened this issue Aug 1, 2024 · 1 comment · Fixed by #5336
Assignees
@accmeboot
Labels
bug Priority: High Team G
Milestone
Ketcher 2.25.0-rc.1

Comments

@AnnaKosol
Copy link
Contributor

Steps to Reproduce

  1. Go to the Settings
  2. Choose cm (or inch, pt) in any field with that dropdown
  3. Enter some number in the field

Actual behavior
I can't enter the numbers i need

2024-08-01.11.38.51.mov

Expected behavior
I can enter any number

Environment details:
Ketcher Version 2.23.0-rc.3 Build at 2024-07-14; 20:34:10
Indigo Version 1.22.0-rc.3.0-gbb5c51fc2-wasm32-wasm-clang-19.0.0
Chrome Версия 126.0.6478.127 (Официальная сборка), (arm64)
MacOs Sonoma 14.5
@accmeboot accmeboot self-assigned this Aug 15, 2024
accmeboot pushed a commit that referenced this issue Aug 16, 2024
#5201 -- removed the meassure recalculation
f71003a
accmeboot pushed a commit that referenced this issue Aug 19, 2024
#5201 -- added validation to the measure input
db9dda1
accmeboot pushed a commit that referenced this issue Aug 21, 2024
#5201 -- added convertion for units
674a904
@accmeboot accmeboot linked a pull request Aug 21, 2024 that will close this issue
#5201 - it is not possible to enter a value when selecting cm inch pt manually in the settings #5336
Merged
9 tasks
accmeboot pushed a commit that referenced this issue Aug 22, 2024
#5201 -- safe guard for units convertion
6fde43b
accmeboot pushed a commit that referenced this issue Aug 23, 2024
#5201 -- conflict fix
32552d9
rrodionov91 pushed a commit that referenced this issue Aug 23, 2024
@accmeboot
#5201 - it is not possible to enter a value when selecting cm inch pt…
0797318 
… manually in the settings (#5336)

* #5201 -- removed the meassure recalculation

* #5201 -- added validation to the measure input

* #5201 -- added convertion for units

* #5201 -- safe guard for units convertion

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
@AnnaKosol
Copy link
Contributor Author

Verified
Image

Environment details:
Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
Chrome Версия 126.0.6478.127 (Официальная сборка), (arm64)
MacOs Sonoma 14.6

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@accmeboot @Guch1g0v
#5201 - it is not possible to enter a value when selecting cm inch pt…
7e91f20 
… manually in the settings (#5336)

* #5201 -- removed the meassure recalculation

* #5201 -- added validation to the measure input

* #5201 -- added convertion for units

* #5201 -- safe guard for units convertion

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@accmeboot accmeboot

Labels
bug Priority: High Team G
Projects
None yet
Milestone
Ketcher 2.25.0-rc.1
3 participants
@accmeboot @AlexeyGirin @AnnaKosol