Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inform User to Apply Layout after Settings Adjustment #5351

Closed
AnnaKosol opened this issue Aug 23, 2024 · 1 comment · Fixed by #5921
Closed

Inform User to Apply Layout after Settings Adjustment #5351

AnnaKosol opened this issue Aug 23, 2024 · 1 comment · Fixed by #5921
Assignees
@mnmsvlw
Labels
ACS standard feature request phase III Team G Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.28.0-rc.1

Comments

@AnnaKosol
Copy link
Contributor

AnnaKosol commented Aug 23, 2024 •
edited
Loading

Background
Related task #5152 the new setting Reaction component margin size were implemented.

Solution
When the user adjusts the "Reaction component margin size" settings and clicks the "Apply" button, an informational message should be displayed, informing the user that these changes require applying the layout to take full effect.

The message: "To fully apply these changes, you need to apply the layout."

The informational window should include an "OK" button for the user to acknowledge the message and close the notification.
accmeboot pushed a commit that referenced this issue Sep 19, 2024
#5351 - changed the fefault size of arrows to be 1 bond length
4c1a3b8
accmeboot pushed a commit that referenced this issue Sep 25, 2024
#5351 - dynamic bond length dependant arrow drawing
245d50d
rrodionov91 pushed a commit that referenced this issue Oct 2, 2024
@rrodionov91
#5351 - changed the fefault size of arrows to be 1 bond length
7998637
rrodionov91 pushed a commit that referenced this issue Oct 2, 2024
@rrodionov91
#5351 - dynamic bond length dependant arrow drawing
a4a27f9
rrodionov91 added a commit that referenced this issue Oct 4, 2024
@accmeboot @rrodionov91
@AlexeyGirin @Zhirnoff
#5351 - Change the default size of a plus and the arrows (#5549)
7a3a053 
* #5351 - Changed the default size of arrows to be 1 bond length
* #5153 - Large unbalanced arrow fix
* #5362 - Updates remote & standalone structs to send appropriate parameters for certain requests
* #5584 - Update indigo to 1.25.0-rc.1 in browser module

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
Co-authored-by: Alexey Girin <agirin@mail.ru>
Co-authored-by: Zhirnoff <mikhail_zhirnov@epam.com>
@AlexanderSavelyev AlexanderSavelyev added this to the Ketcher 2.27.0-rc.1 milestone Oct 7, 2024
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@accmeboot @rrodionov91
@AlexeyGirin @Zhirnoff @Guch1g0v
#5351 - Change the default size of a plus and the arrows (#5549)
eaabcf1 
* #5351 - Changed the default size of arrows to be 1 bond length
* #5153 - Large unbalanced arrow fix
* #5362 - Updates remote & standalone structs to send appropriate parameters for certain requests
* #5584 - Update indigo to 1.25.0-rc.1 in browser module

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
Co-authored-by: Alexey Girin <agirin@mail.ru>
Co-authored-by: Zhirnoff <mikhail_zhirnov@epam.com>
@mnmsvlw mnmsvlw self-assigned this Nov 4, 2024
mnmsvlw added a commit that referenced this issue Nov 5, 2024
@mnmsvlw
#5351 - inform user to apply layout after settings adjustment
c33ba74
@mnmsvlw mnmsvlw linked a pull request Nov 5, 2024 that will close this issue
#5351 – Inform User to Apply Layout after Settings Adjustment #5921
Merged
9 tasks
mnmsvlw added a commit that referenced this issue Nov 6, 2024
@mnmsvlw
#5351 - inform user to apply layout after settings adjustment
6e844cc
NataliaLoginova pushed a commit that referenced this issue Nov 7, 2024
@mnmsvlw
#5351 – Inform User to Apply Layout after Settings Adjustment (#5921)
94e560b 
* #5351 - inform user to apply layout after settings adjustment

* Update reaction component margin size related tests
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Nov 12, 2024
knadonenko pushed a commit that referenced this issue Nov 12, 2024
@knadonenkoepam
Squashed commit of the following:
36e77ab 
commit 0bb3715
Author: Drimodaren <95479023+Drimodaren@users.noreply.github.com>
Date:   Tue Nov 12 12:08:05 2024 +0400

    #5842-info-button-i-for-some-properties-at-settings (#5912)

    * 5842-info-button-i-for-some-properties-at-settings

    * updated tests

    * change layout and update snapshot

    * updated test

    * updated tests

    * merge

    * add tooltip for after, updated tests

    * changes part 2

    * tests update

    * update tests

    * update tests

    * Revert specific files to previous state

    * Revert specific files to previous state

    * Revert specific files to previous state

    * format

    ---------

    Co-authored-by: Andrey Menshikov <andrey.menshikov@bostongene.com>

commit 168e713
Author: Alexey Girin <agirin@mail.ru>
Date:   Mon Nov 11 16:29:38 2024 +0300

    Autotests: #5832 - autotests expand macromolecules in micro mode 2 (#5913)

    * First banch

    * For Roman

    * For roman 2

    * - added clickOnAtomById helper

    * Zoom coordinates recalculation added

    * Verify that deleting an expanded monomer in a chain structure using the Erase tool cause Edit Abbreviations dialog to appear

    * fix

    * Verify that after using the Erase tool to delete an expanded monomer in both chain and ring structures, the Undo and Redo functionality works correctly, restoring or re-removing the expanded monomer and its bonds

    * Move collapsed monomer on Micro and Undo

    * Move expanded monomer on Micro and Undo

    * Verify switching back from micro mode to macro mode with expanded and collapsed monomers

    * Small fix

    * first draft

    * Verify saving collapsed monomers in Daylight SMARTS

    * Saving collapsed monomer to SMARTS

    * Last fix

    * last fix

    * lf 2

    * lf3

    * Micro molecules fix

    * lf4

    * Verify that expanding multiple monomers works in a left-to-right order within a chain fix

    * Verify that expanding multiple monomers works in a top-to-bottom order within a chain fix

    * Verify that expanding monomers with big mircomolecule ring structures in the middle behaves correctly without breaking the chain fix

    * Verify that deleting an expanded monomer in a chain structure using the Erase tool cause Edit Abbreviations dialog to appear fix

    * last fix

    * lf2

    * Move collapsed monomer on Micro and Undo fix

    * Last fix

    * last last fix

    * One more try

    * One more fix

    * macro-micro-switcher.spec.ts:3232 update

    * macro-micro-switcher.spec.ts:3093 update

    * all the rest

    * final

    * Horizontal split

    * one more fix

    * On more try

    * one more try

    * and one more

    * 260

    * last one

    * lf 2

    ---------

    Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>

commit 94e560b
Author: Vladimir Nebolsin <107650674+mnmsvlw@users.noreply.github.com>
Date:   Fri Nov 8 03:56:30 2024 +0400

    #5351 – Inform User to Apply Layout after Settings Adjustment (#5921)

    * #5351 - inform user to apply layout after settings adjustment

    * Update reaction component margin size related tests

commit eb21a9d
Author: GlisicMirjana <133213397+GlisicMirjana@users.noreply.github.com>
Date:   Wed Nov 6 23:06:53 2024 +0100

    #5270 - Warning should not displayed for importing CDXML, base64 CDX, CDX formats (#5928)

commit 5a281ac
Author: Roman Rodionov <roman_rodionov@epam.com>
Date:   Wed Nov 6 16:26:42 2024 +0100

    Backmerge: #5886 - Loading a KET file in macro mode, bond connections are preserved but microstructures are shifted (#5919)

    - added repositioning for all entities during paste/open structures
    - updated screenshots

commit 5fe4ef3
Author: Roman Rodionov <roman_rodionov@epam.com>
Date:   Wed Nov 6 13:08:20 2024 +0100

    #5814 - On Remote environment, the reaction/molecule can't be saved to V3000 formats (returns V2000 instead): MOL, RXN, SDF, RDF (#5908) (#5911)

commit 9a1e91e
Author: ivanmaslow <165396466+ivanmaslow@users.noreply.github.com>
Date:   Wed Nov 6 14:54:14 2024 +0300

    #5915: Added two files, two tests, updated description (#5917)

commit 3a57f09
Author: aproskurnov <proskurn@gmail.com>
Date:   Wed Nov 6 11:39:28 2024 +0100

    Backmerge - #5833 Applied functional group drawing settings (#5883)

    * * applied functional group drawing settings

    * added micromolecules tests

    * added macromolecules tests

    * fixed bunch of micromol tests

    * fixed bunch of macromol tests

    * fixed micromolecule tests

    * fixed macro tests

    * fixed macromolecule tests

    * fixed micromolecule tests

    * fixed imports

    * fixed macro test

    * fixed micro tests

commit 7851c09
Author: Roman Rodionov <roman_rodionov@epam.com>
Date:   Wed Nov 6 10:54:25 2024 +0100

    #5873 - Export to ket (and getKET function) change incrementally internal IDs every call (#5916)

    - fixed monomer ids generation for serialization
    - updated test-data

commit eb5738f
Author: Nikita Chistousov <nikita_chistousov@epam.com>
Date:   Tue Nov 5 15:00:12 2024 +0100

    #5898 – Update indigo to 1.26.0-rc.1 in browser module (#5905)

    – updated indigo to 1.26.0-rc.1 in browser module
    - removed test which doesn't work

    ---------

    Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>

commit a691731
Author: Nikita Chistousov <nikita_chistousov@epam.com>
Date:   Mon Nov 4 12:28:53 2024 +0100

    Backmerge: #5809 – Open correct context menu for expanded monomer while clicking on bond or atom (#5901)
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Ketcher Version 2.28.0-rc.1 Build at 2024-12-03; 17:04:52
  • Indigo Version 1.27.0-rc.1.0-g8d656a341-wasm32-wasm-clang-19.0.0
  • Chrome Version 131.0.6778.109 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnmsvlw mnmsvlw

Labels
ACS standard feature request phase III Team G Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.28.0-rc.1
Development

Successfully merging a pull request may close this issue.

#5351 – Inform User to Apply Layout after Settings Adjustment epam/ketcher
5 participants
@AlexanderSavelyev @rrodionov91 @AlexeyGirin @mnmsvlw @AnnaKosol