Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't add specific SVG image to Canvas in Mozilla Firefox #5413

Closed
ivanmaslow opened this issue Sep 2, 2024 · 2 comments · Fixed by #5811 or #5837
Closed

Can't add specific SVG image to Canvas in Mozilla Firefox #5413

ivanmaslow opened this issue Sep 2, 2024 · 2 comments · Fixed by #5811 or #5837
Assignees
@daniil-sloboda
Labels
bug Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Milestone
Ketcher 2.26.0-rc.6

Comments

@ivanmaslow
Copy link
Collaborator

Steps to Reproduce

  1. Open the Ketcher in Mozilla Firefox
  2. Click "Add Image" button
  3. Click on Canvas
  4. Select this SVG image:
    SVG_Logo 1.zip

Actual behavior

  • Error message is displayed:
    image

Expected behavior

  • Image is added to selected place to Canvas as it work in Google Chrome:
    image

Environment Details:

  • Ketcher [Version 2.24.0-rc.3] Build at 2024-08-20; 13:16:59
  • Indigo Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • OS: Windows 11 Enterprise
  • Browser: Mozilla Firefox Version 129.0.2 (64-Bit)

Additional context
@ivanmaslow ivanmaslow added bug Priority: Medium Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Sep 2, 2024
@ivanmaslow ivanmaslow added this to the Ketcher 2.26.0-rc.1 milestone Sep 2, 2024
@daniil-sloboda daniil-sloboda self-assigned this Oct 18, 2024
daniil-sloboda added a commit that referenced this issue Oct 18, 2024
@daniil-sloboda
#5413 - fixed sizeless svg issue
665aa4d
@rrodionov91 rrodionov91 linked a pull request Oct 18, 2024 that will close this issue
Backmerge: #5413 - Can't add specific SVG image to Canvas in Mozilla Firefox #5811
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Oct 18, 2024
@daniil-sloboda
#5413 - fixed sizeless svg issue (#5811)
f2ebb14
@rrodionov91 rrodionov91 reopened this Oct 18, 2024
@rrodionov91
Copy link
Collaborator

Need to be merged in 2.26

daniil-sloboda added a commit that referenced this issue Oct 22, 2024
@daniil-sloboda
#5413 - fixed sizeless svg issue (#5811)
32ccf38
@daniil-sloboda daniil-sloboda linked a pull request Oct 22, 2024 that will close this issue
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one #5837
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Oct 22, 2024
@daniil-sloboda
#5753 - Issue with moving of tail of Multi-Tailed arrow with several …
0367370 
…tails when user needs to move the tail close to another one

#5413 - Fixed sizeless svg issue
#5786 - Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails
#5776 - Add API Method getRdf for retrieving RDF representation of structures
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Oct 26, 2024 •
edited
Loading

Tested. Bug fixed.
2024-10-26_13h03_18

Desktop:

  • OS: Windows 11
  • Browser Mozilla
  • Version 131.0 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.6]
Indigo version
[Version 1.25.0-rc.4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniil-sloboda daniil-sloboda

Labels
bug Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Projects
None yet
Milestone
Ketcher 2.26.0-rc.6
7 participants
@svvald @rrodionov91 @AlexeyGirin @Zhirnoff @ivanmaslow @yauhen-karmyzau @daniil-sloboda