Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export of variant monomers to Sequence/FASTA doesn't work for presets #5454

Closed
AlexeyGirin opened this issue Sep 9, 2024 · 1 comment · Fixed by #5456 or #5483
Closed

Export of variant monomers to Sequence/FASTA doesn't work for presets #5454

AlexeyGirin opened this issue Sep 9, 2024 · 1 comment · Fixed by #5456 or #5483
Assignees
@rrodionov91
Labels
bug FASTA Bucket: FASTA related issues Priority: High Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.25.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Toggle to Macro - Flex
  2. Load using paste from clipboard way following peptide via sequence: Y
    image
  3. Try to export canvas to Sequence (or FASTA - result is the same)

Actual behavior
System throws exception: Convert error! Error during sequence type recognition(RNA, DNA or Peptide)
image

Expected behavior
No exception. Export works as intended - sequence string: Y

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Reference issues: epam/Indigo#2015
@AlexeyGirin AlexeyGirin added bug Priority: High FASTA Bucket: FASTA related issues Sequence mode Bucket: Sequence mode related issues labels Sep 9, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.25.0-rc.2 milestone Sep 9, 2024
rrodionov91 added a commit that referenced this issue Sep 9, 2024
@rrodionov91
#5454 - Export of variant monomers to Sequence/FASTA doesn't work for…
dcb915e 
… presets

- fixed fasta validation for ambiguous monomers
@rrodionov91 rrodionov91 self-assigned this Sep 9, 2024
@rrodionov91 rrodionov91 linked a pull request Sep 9, 2024 that will close this issue
#5454 - Export of variant monomers to Sequence/FASTA doesn't work for presets #5456
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 9, 2024
@rrodionov91
#5454 - Export of variant monomers to Sequence/FASTA doesn't work for…
34c151b 
… presets (#5456)

- fixed fasta validation for ambiguous monomers
rrodionov91 added a commit that referenced this issue Sep 10, 2024
@rrodionov91
#5454 - Export of variant monomers to Sequence/FASTA doesn't work for…
ccea23e 
… presets

- fixed fasta validation for ambiguous monomers
@rrodionov91 rrodionov91 linked a pull request Sep 10, 2024 that will close this issue
Backmerge: #5454 - Export of variant monomers to Sequence/FASTA doesn't work for presets #5483
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 11, 2024
@rrodionov91
#5454 - Export of variant monomers to Sequence/FASTA doesn't work for…
9fc0c76 
… presets (#5483)

- fixed fasta validation for ambiguous monomers
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

Versions

  • Ketcher Version 2.25.0-rc.2 Build at 2024-09-14; 10:47:47
  • Indigo Toolkit Version 1.24.0-rc.2.0-g5f2751d70-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.138 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
#5454 - Export of variant monomers to Sequence/FASTA doesn't work for…
8639a66 
… presets (#5483)

- fixed fasta validation for ambiguous monomers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug FASTA Bucket: FASTA related issues Priority: High Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.25.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin