Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After opening a saved HELM file, microstructure F1 turns into Base (Mod0) #5513

Closed
Zhirnoff opened this issue Sep 5, 2024 · 5 comments
Closed
Assignees
Labels
bug HELM Bucket: Bugs related to Export to HELM format Priority: High

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Sep 5, 2024

Summary
After opening a saved HELM file, microstructure F1 turns into Base (Mod0)

Steps to Reproduce

  1. Open file in Macro Unable.to.save.micro-molecule.connected.to.CHEM.to.HELM.zip
  2. Save as HELM
  3. Open saved file

Expected behavior
The structures look the same as before saving.
2024-09-05_13h13_02

Actual behavior
After opening a saved HELM file, microstructure F1 turns into Base (Mod0)
2024-09-05_11h42_19
Saved HELM file ketcher (2).zip

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.1]
Indigo version
[Version 1.24.0-rc.1]

Additional context
Bug found during testing:
epam/Indigo#2189
epam/Indigo#2073

@Zhirnoff Zhirnoff added bug Priority: High HELM Bucket: Bugs related to Export to HELM format labels Sep 5, 2024
@AliaksandrDziarkach AliaksandrDziarkach transferred this issue from epam/Indigo Sep 13, 2024
@AliaksandrDziarkach
Copy link
Collaborator

This monomer has class CHEM:

        "class": "CHEM",
        "id": "Mod0",
        "fullName": "Mod0",
        "alias": "Mod0",
        "attachmentPoints": [

@Zhirnoff
Copy link
Collaborator Author

But this is a Benzene ring with added attachment points. And if we switch to macro mode, the microstructures should are displayed as a square with the abbreviation F1.

@AliaksandrDziarkach
Copy link
Collaborator

Correct - it should be displayed as a sqiare as other chems, but it displayed as base.
It is ketcher issue.

@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Sep 16, 2024

@AliaksandrDziarkach And name on it should be F1 but we have Mod0

@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Sep 16, 2024

Tested. The bug has been fixed only for visual display of the microstructure as CHEM instead of Base, but instead of F1, the name Mod0 is displayed on the structure. A separate bug has been created for this on the Indigo side epam/Indigo#2387
FYI @rrodionov91
2024-09-16_16h21_11

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.2]
Indigo version
[Version 1.24.0-rc.2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug HELM Bucket: Bugs related to Export to HELM format Priority: High
Projects
None yet
Development

No branches or pull requests

3 participants