Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O and U sumbols are not supported in sequence mode #5621

Closed
AlexeyGirin opened this issue Sep 24, 2024 · 1 comment · Fixed by #5718 or #5734
Closed

O and U sumbols are not supported in sequence mode #5621

AlexeyGirin opened this issue Sep 24, 2024 · 1 comment · Fixed by #5718 or #5734
Assignees
@rrodionov91
Labels
bug Ljubica found bugs Bucket: Bugs found by Ljubica on her daily routine Priority: High Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.26.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Sep 24, 2024 •
edited by Zhirnoff
Loading

Steps to Reproduce

  1. Toggle to Macro - Sequence mode -> Switch to PEP (Peptides)
  2. Start new sequence
  3. Type OU

Actual behavior
Canvas is empty
image

Expected behavior
OU appeared on the canvas
image

Investigation:

  1. Where was no task for peptide support in sequence mode (in road map - no ticket id)
  2. O and U symbols haven't been supported because we didn't have such peptides in the Library
  3. Others symbols have been supported in the context of import/export to FASTA/Sequence
  4. And O symbol was missed even there - Import and export fasta format for RNA, DNA and PEPTIDES Indigo#1755 (comment)

Versions

  • Ketcher Version 2.25.0-rc.4 Build at 2024-09-23; 17:24:38
  • Indigo Toolkit Version 1.24.0-rc.3.0-g692080c62-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.59 (Official Build) (64-bit)
  • Win10
@AlexeyGirin AlexeyGirin added bug Priority: High Sequence mode Bucket: Sequence mode related issues Ljubica found bugs Bucket: Bugs found by Ljubica on her daily routine labels Sep 24, 2024
@AlexeyGirin AlexeyGirin transferred this issue from epam/Indigo Oct 2, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.26.0-rc.2 milestone Oct 2, 2024
@rrodionov91 rrodionov91 self-assigned this Oct 10, 2024
rrodionov91 added a commit that referenced this issue Oct 10, 2024
@rrodionov91
#5621 - O and U sumbols are not supported in sequence mode
a31520d
@rrodionov91 rrodionov91 linked a pull request Oct 10, 2024 that will close this issue
#5621 - O and U sumbols are not supported in sequence mode #5718
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 13, 2024
@rrodionov91
#5621 - O and U sumbols are not supported in sequence mode (#5718)
5678990
rrodionov91 added a commit that referenced this issue Oct 13, 2024
@rrodionov91
#5621 - O and U sumbols are not supported in sequence mode
00bed07
@rrodionov91 rrodionov91 linked a pull request Oct 13, 2024 that will close this issue
Backmerge: #5621 - O and U sumbols are not supported in sequence mode #5734
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 13, 2024
@rrodionov91
#5621 - O and U sumbols are not supported in sequence mode
b2f1690
rrodionov91 added a commit that referenced this issue Oct 14, 2024
@rrodionov91
Backmerge: #5621 - O and U sumbols are not supported in sequence mode (…
ca97652 
…#5734)
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.
2024-10-15_17h51_48

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.2]
Indigo version
[Version 1.25.0-rc.2]

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5621 - O and U sumbols are not supported in sequence mode (…
01d3f7f 
…#5734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Ljubica found bugs Bucket: Bugs found by Ljubica on her daily routine Priority: High Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.26.0-rc.2
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff