Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holding CTRL and clicking on an atom or bond creates multiple duplicated structures until clicking on canvas, with console errors #5672

Closed
Zhirnoff opened this issue Oct 7, 2024 · 2 comments · Fixed by #5720 or #5723

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Oct 7, 2024

Steps to Reproduce

  1. Open Ketcher and draw a chemical structure on canvas ( e.g. Benzene ring and Chain )
  2. Hold down the "Ctrl" key and click on any atom or bond
  3. Release left mouse button and without releasing "CTRL," continue moving mouse
  4. Observe the behavior of structures on canvas

Actual behavior
Holding CTRL and clicking on an atom or bond creates multiple duplicated structures until clicking on canvas, with console errors

2024-10-07_17h33_34.mp4

Expected behavior
On Prod, when CTRL was pressed, the entire structure was highlighted on hover and when clicking on an atom or bond, it was all structure selected

2024-10-07_17h37_26.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.1]
Indigo version
[Version 1.25.0-rc.1]

Bug related to: #4986

@aproskurnov
Copy link
Contributor

aproskurnov commented Oct 10, 2024

Regarding the second part of issue, because of new functionality for "ctrl" + click event, previous functionality has been moved to "alt" button.
First part will be fixed in PR

NataliaLoginova pushed a commit that referenced this issue Oct 11, 2024
* change rendering of highlights

* fixed macromolecule tests

* fixed indigo-tools tests

* fixed part bonds tests

* fixed bonds tests

* fixed rotation tests

* fixed layout tests

* fixed functional group tests

* bunch of tests

* bunch of tests

* fixed bunch of tests

* fixed test snapshot

* fix snapshot

* fixed bunch of tests

* update test file

* rollback redundant changes

* revert changes isCopy

* fixed multiple duplicating issue

---------

Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
aproskurnov added a commit that referenced this issue Oct 11, 2024
* change rendering of highlights

* fixed macromolecule tests

* fixed indigo-tools tests

* fixed part bonds tests

* fixed bonds tests

* fixed rotation tests

* fixed layout tests

* fixed functional group tests

* bunch of tests

* bunch of tests

* fixed bunch of tests

* fixed test snapshot

* fix snapshot

* fixed bunch of tests

* update test file

* rollback redundant changes

* revert changes isCopy

* fixed multiple duplicating issue

---------

Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
NataliaLoginova pushed a commit that referenced this issue Oct 11, 2024
* change rendering of highlights

* fixed macromolecule tests

* fixed indigo-tools tests

* fixed part bonds tests

* fixed bonds tests

* fixed rotation tests

* fixed layout tests

* fixed functional group tests

* bunch of tests

* bunch of tests

* fixed bunch of tests

* fixed test snapshot

* fix snapshot

* fixed bunch of tests

* update test file

* rollback redundant changes

* revert changes isCopy

* fixed multiple duplicating issue

---------

Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
rrodionov91 pushed a commit that referenced this issue Oct 13, 2024
* change rendering of highlights

* fixed macromolecule tests

* fixed indigo-tools tests

* fixed part bonds tests

* fixed bonds tests

* fixed rotation tests

* fixed layout tests

* fixed functional group tests

* bunch of tests

* bunch of tests

* fixed bunch of tests

* fixed test snapshot

* fix snapshot

* fixed bunch of tests

* update test file

* rollback redundant changes

* revert changes isCopy

* fixed multiple duplicating issue

---------

Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug fixed.

2024-10-15_15h40_55.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.2]
Indigo version
[Version 1.25.0-rc.2]

@aproskurnov aproskurnov linked a pull request Oct 17, 2024 that will close this issue
9 tasks
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
* change rendering of highlights

* fixed macromolecule tests

* fixed indigo-tools tests

* fixed part bonds tests

* fixed bonds tests

* fixed rotation tests

* fixed layout tests

* fixed functional group tests

* bunch of tests

* bunch of tests

* fixed bunch of tests

* fixed test snapshot

* fix snapshot

* fixed bunch of tests

* update test file

* rollback redundant changes

* revert changes isCopy

* fixed multiple duplicating issue

---------

Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment