Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor position is incorrect when editing sequence in Macro mode #5725

Closed
Zhirnoff opened this issue Oct 11, 2024 · 1 comment · Fixed by #5783 or #5813
Closed

Cursor position is incorrect when editing sequence in Macro mode #5725

Zhirnoff opened this issue Oct 11, 2024 · 1 comment · Fixed by #5783 or #5813
Assignees
@rrodionov91
Labels
bug Priority: High Sequence mode Bucket: Sequence mode related issues User's Feedback
Milestone
Ketcher 2.26.0-rc.4

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Oct 11, 2024 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher and switch to Macro mode.
  2. Add a sequence of monomers to the canvas.
  3. Right-click on a monomer ( or double click ) in the sequence (e.g., the 8th monomer) and start editing the sequence.

Actual behavior
The cursor appears to the left of the monomer that was clicked, which is inconsistent with the expected editing behavior. This can lead to confusion when modifying the sequence.
2024-10-11_13h36_17

Expected behavior
The cursor should appear to the right of the monomer on which the right-click ( double click ) was made, allowing for editing after the selected monomer
2024-10-11_13h36_31

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.1]
Indigo version
[Version 1.25.0-rc.1]
Bug related to task: #4888
#187898331
@Zhirnoff Zhirnoff added bug Priority: High User's Feedback Sequence mode Bucket: Sequence mode related issues labels Oct 11, 2024
@Zhirnoff Zhirnoff added this to the Ketcher 2.26.0-rc.2 milestone Oct 11, 2024
@rrodionov91 rrodionov91 self-assigned this Oct 15, 2024
rrodionov91 added a commit that referenced this issue Oct 16, 2024
@rrodionov91
#5725 - Cursor position is incorrect when editing sequence in Macro mode
29b4400
@rrodionov91 rrodionov91 linked a pull request Oct 16, 2024 that will close this issue
#5725 - Cursor position is incorrect when editing sequence in Macro mode #5783
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 18, 2024
@rrodionov91
#5725 - Cursor position is incorrect when editing sequence in Macro m…
015d2e5 
…ode (#5783)
rrodionov91 added a commit that referenced this issue Oct 18, 2024
@rrodionov91
#5725 - Cursor position is incorrect when editing sequence in Macro m…
9581bb1 
…ode (#5783)
@rrodionov91 rrodionov91 linked a pull request Oct 18, 2024 that will close this issue
Backmerge: #5725 - Cursor position is incorrect when editing sequence in Macro mode #5813
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 18, 2024
@rrodionov91
#5725 - Cursor position is incorrect when editing sequence in Macro m…
65d63e3 
…ode (#5783)
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug fixed.

2024-10-21_12h42_54.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.4]
Indigo version
[Version 1.25.0-rc.2]

rrodionov91 added a commit that referenced this issue Oct 22, 2024
@rrodionov91
Backmerge: #5725 - Cursor position is incorrect when editing sequence…
114ff3d 
… in Macro mode (#5813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High Sequence mode Bucket: Sequence mode related issues User's Feedback
Projects
None yet
Milestone
Ketcher 2.26.0-rc.4
2 participants
@rrodionov91 @Zhirnoff