Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one #5753

Closed
ivanmaslow opened this issue Oct 14, 2024 · 2 comments · Fixed by #5806 or #5837
Closed

Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one #5753

ivanmaslow opened this issue Oct 14, 2024 · 2 comments · Fixed by #5806 or #5837
Assignees
@daniil-sloboda
Labels
bug MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool Priority: Medium
Milestone
Ketcher 2.26.0-rc.6

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Oct 14, 2024 •
edited
Loading

Steps to Reproduce

  1. Add Multi-Tailed Arrow (MTA) to Canvas:
    image

  2. Right-click on MTA, add two tails:
    image

  3. Move up top tail to increase the length of the spine:
    image

  4. Try to put the third tail a little bit upper then the second tail:
    image

Actual behavior

  • The third tail isn't positioned upper, it comes back in the minimal distance (0.35) under the second tail:
    image

Expected behavior

  • The third tail is positioned upper then the second tail
  • It is in the minimal distance (0.35) above the second tail if it is moved closer than the minimal distance to the second tail
    image

Environment Details

  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-04; 18:45:04
  • Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)

Notes

chrome_9BMgV8Cgd8.mp4
@ivanmaslow ivanmaslow added bug Priority: Medium MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool labels Oct 14, 2024
@ivanmaslow ivanmaslow changed the title Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail closer to another one Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one Oct 14, 2024
@ivanmaslow ivanmaslow mentioned this issue Oct 15, 2024
Closed
daniil-sloboda added a commit that referenced this issue Oct 17, 2024
@daniil-sloboda
#5753: Fixed issue with tail normalization when moving
cdada70
@daniil-sloboda daniil-sloboda linked a pull request Oct 18, 2024 that will close this issue
Backmerge: #5753 - Fixed issue with tail normalization when moving #5806
Merged
9 tasks
daniil-sloboda added a commit that referenced this issue Oct 18, 2024
@daniil-sloboda
#5753 - fixed typo
3c4be79
rrodionov91 pushed a commit that referenced this issue Oct 18, 2024
@daniil-sloboda
Backmerge: #5753 - Fixed issue with tail normalization when moving (#…
631993d 
…5806)

#5786 - Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails
#5776 - Add API Method getRdf for retrieving RDF representation of structures
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one
@rrodionov91
Copy link
Collaborator

Need merge into 2.26

@rrodionov91 rrodionov91 reopened this Oct 18, 2024
daniil-sloboda added a commit that referenced this issue Oct 22, 2024
@daniil-sloboda
Backmerge: #5753 - Fixed issue with tail normalization when moving (#…
25d0bf7 
…5806)

#5786 - Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails
#5776 - Add API Method getRdf for retrieving RDF representation of structures
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one
@daniil-sloboda daniil-sloboda linked a pull request Oct 22, 2024 that will close this issue
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one #5837
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Oct 22, 2024
@daniil-sloboda
#5753 - Issue with moving of tail of Multi-Tailed arrow with several …
0367370 
…tails when user needs to move the tail close to another one

#5413 - Fixed sizeless svg issue
#5786 - Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails
#5776 - Add API Method getRdf for retrieving RDF representation of structures
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.

2024-10-25_15h07_59.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.6]
Indigo version
[Version 1.25.0-rc.4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniil-sloboda daniil-sloboda

Labels
bug MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool Priority: Medium
Projects
None yet
Milestone
Ketcher 2.26.0-rc.6
7 participants
@svvald @rrodionov91 @AlexeyGirin @Zhirnoff @ivanmaslow @yauhen-karmyzau @daniil-sloboda