Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing functional groups (e.g. Boc, Bn, CF3) ignores drawing settings (e.g. ACS style) #5833

Closed
AlexeyGirin opened this issue Oct 22, 2024 · 4 comments · Fixed by #5874, #5883 or #5944
Closed

Importing functional groups (e.g. Boc, Bn, CF3) ignores drawing settings (e.g. ACS style) #5833

AlexeyGirin opened this issue Oct 22, 2024 · 4 comments · Fixed by #5874, #5883 or #5944
Assignees
@aproskurnov
Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: High Team G User's Feedback
Milestone
Ketcher 2.26.0-rc.7

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Oct 22, 2024 •
edited
Loading

Steps to Reproduce

  1. Add any functional group on the canvas
    (or load from file: Importing functional groups (e.g. Boc, Bn, CF3) ignores drawing settings (e.g. ACS style) and is bolded.zip )
    image
  2. Go to Settings - General tab
  3. Set Font size to 30 pt and Font to Symbol
    image
  4. Click on layout Apply

Actual behavior
Functional group label remain unchanged
image

Expected behavior
Functional group label font and font size got changed
image

Versions

  • Ketcher Version 2.26.0-rc.3 Build at 2024-10-16; 14:35:25
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

Found while testing - #4987
@AlexeyGirin AlexeyGirin added bug User's Feedback Micromolecules canvas Bucket: Micromolecules canvas related issues Team G labels Oct 22, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.26.0-rc.6 milestone Oct 22, 2024
@AlexeyGirin AlexeyGirin changed the title Importing functional groups (e.g. Boc, Bn, CF3) ignores drawing settings (e.g. ACS style) and is bolded. Importing functional groups (e.g. Boc, Bn, CF3) ignores drawing settings (e.g. ACS style). Oct 23, 2024
@AlexeyGirin AlexeyGirin changed the title Importing functional groups (e.g. Boc, Bn, CF3) ignores drawing settings (e.g. ACS style). Importing functional groups (e.g. Boc, Bn, CF3) ignores drawing settings (e.g. ACS style) Oct 23, 2024
NataliaLoginova pushed a commit that referenced this issue Oct 29, 2024
@aproskurnov
#5833 - Importing functional groups (e.g. Boc, Bn, CF3) ignores drawi…
5e8843c 
…ng settings (#5874)

* applied functional group drawing settings

* added micromolecules tests

* added macromolecules tests

* fixed bunch of micromol tests

* fixed bunch of macromol tests
@NataliaLoginova NataliaLoginova linked a pull request Oct 29, 2024 that will close this issue
#5833 - Importing functional groups (e.g. Boc, Bn, CF3) ignores drawing settings #5874
Merged
9 tasks
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Ketcher Version 2.26.0-rc.7 Build at 2024-11-04; 15:18:23
  • Indigo Toolkit Version 1.25.0-rc.4.0-g8862ccb7e-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.92 (Official Build) (64-bit)
  • Win10

NataliaLoginova pushed a commit that referenced this issue Nov 6, 2024
@aproskurnov
Backmerge - #5833 Applied functional group drawing settings (#5883)
3a57f09 
* * applied functional group drawing settings

* added micromolecules tests

* added macromolecules tests

* fixed bunch of micromol tests

* fixed bunch of macromol tests

* fixed micromolecule tests

* fixed macro tests

* fixed macromolecule tests

* fixed micromolecule tests

* fixed imports

* fixed macro test

* fixed micro tests
@NataliaLoginova
Copy link
Collaborator

NataliaLoginova commented Nov 6, 2024 •
edited
Loading

Changes were merged into master branch in PR #5883

@NataliaLoginova NataliaLoginova mentioned this issue Nov 6, 2024
Merged
9 tasks
@NataliaLoginova NataliaLoginova linked a pull request Nov 6, 2024 that will close this issue
Backmerge - #5833 Applied functional group drawing settings #5883
Merged
9 tasks
@rrodionov91 rrodionov91 reopened this Nov 6, 2024
@rrodionov91
Copy link
Collaborator

Need backmerge to 2.27

aproskurnov added a commit that referenced this issue Nov 7, 2024
@aproskurnov
Backmerge - #5833 Applied functional group drawing settings (#5883)
2833068 
* * applied functional group drawing settings

* added micromolecules tests

* added macromolecules tests

* fixed bunch of micromol tests

* fixed bunch of macromol tests

* fixed micromolecule tests

* fixed macro tests

* fixed macromolecule tests

* fixed micromolecule tests

* fixed imports

* fixed macro test

* fixed micro tests
NataliaLoginova pushed a commit that referenced this issue Nov 8, 2024
@aproskurnov
#5833 227 apply functional group drawing setting (#5944)
0658035 
* Backmerge - #5833 Applied functional group drawing settings (#5883)

* * applied functional group drawing settings

* added micromolecules tests

* added macromolecules tests

* fixed bunch of micromol tests

* fixed bunch of macromol tests

* fixed micromolecule tests

* fixed macro tests

* fixed macromolecule tests

* fixed micromolecule tests

* fixed imports

* fixed macro test

* fixed micro tests

* fixed macro tests
@NataliaLoginova NataliaLoginova linked a pull request Nov 8, 2024 that will close this issue
#5833 227 apply functional group drawing setting #5944
Merged
9 tasks
@NataliaLoginova
Copy link
Collaborator

Changes were merged into release/2.27 branch in PR #5944

knadonenko pushed a commit that referenced this issue Nov 12, 2024
@knadonenkoepam
Squashed commit of the following:
36e77ab 
commit 0bb3715
Author: Drimodaren <95479023+Drimodaren@users.noreply.github.com>
Date:   Tue Nov 12 12:08:05 2024 +0400

    #5842-info-button-i-for-some-properties-at-settings (#5912)

    * 5842-info-button-i-for-some-properties-at-settings

    * updated tests

    * change layout and update snapshot

    * updated test

    * updated tests

    * merge

    * add tooltip for after, updated tests

    * changes part 2

    * tests update

    * update tests

    * update tests

    * Revert specific files to previous state

    * Revert specific files to previous state

    * Revert specific files to previous state

    * format

    ---------

    Co-authored-by: Andrey Menshikov <andrey.menshikov@bostongene.com>

commit 168e713
Author: Alexey Girin <agirin@mail.ru>
Date:   Mon Nov 11 16:29:38 2024 +0300

    Autotests: #5832 - autotests expand macromolecules in micro mode 2 (#5913)

    * First banch

    * For Roman

    * For roman 2

    * - added clickOnAtomById helper

    * Zoom coordinates recalculation added

    * Verify that deleting an expanded monomer in a chain structure using the Erase tool cause Edit Abbreviations dialog to appear

    * fix

    * Verify that after using the Erase tool to delete an expanded monomer in both chain and ring structures, the Undo and Redo functionality works correctly, restoring or re-removing the expanded monomer and its bonds

    * Move collapsed monomer on Micro and Undo

    * Move expanded monomer on Micro and Undo

    * Verify switching back from micro mode to macro mode with expanded and collapsed monomers

    * Small fix

    * first draft

    * Verify saving collapsed monomers in Daylight SMARTS

    * Saving collapsed monomer to SMARTS

    * Last fix

    * last fix

    * lf 2

    * lf3

    * Micro molecules fix

    * lf4

    * Verify that expanding multiple monomers works in a left-to-right order within a chain fix

    * Verify that expanding multiple monomers works in a top-to-bottom order within a chain fix

    * Verify that expanding monomers with big mircomolecule ring structures in the middle behaves correctly without breaking the chain fix

    * Verify that deleting an expanded monomer in a chain structure using the Erase tool cause Edit Abbreviations dialog to appear fix

    * last fix

    * lf2

    * Move collapsed monomer on Micro and Undo fix

    * Last fix

    * last last fix

    * One more try

    * One more fix

    * macro-micro-switcher.spec.ts:3232 update

    * macro-micro-switcher.spec.ts:3093 update

    * all the rest

    * final

    * Horizontal split

    * one more fix

    * On more try

    * one more try

    * and one more

    * 260

    * last one

    * lf 2

    ---------

    Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>

commit 94e560b
Author: Vladimir Nebolsin <107650674+mnmsvlw@users.noreply.github.com>
Date:   Fri Nov 8 03:56:30 2024 +0400

    #5351 – Inform User to Apply Layout after Settings Adjustment (#5921)

    * #5351 - inform user to apply layout after settings adjustment

    * Update reaction component margin size related tests

commit eb21a9d
Author: GlisicMirjana <133213397+GlisicMirjana@users.noreply.github.com>
Date:   Wed Nov 6 23:06:53 2024 +0100

    #5270 - Warning should not displayed for importing CDXML, base64 CDX, CDX formats (#5928)

commit 5a281ac
Author: Roman Rodionov <roman_rodionov@epam.com>
Date:   Wed Nov 6 16:26:42 2024 +0100

    Backmerge: #5886 - Loading a KET file in macro mode, bond connections are preserved but microstructures are shifted (#5919)

    - added repositioning for all entities during paste/open structures
    - updated screenshots

commit 5fe4ef3
Author: Roman Rodionov <roman_rodionov@epam.com>
Date:   Wed Nov 6 13:08:20 2024 +0100

    #5814 - On Remote environment, the reaction/molecule can't be saved to V3000 formats (returns V2000 instead): MOL, RXN, SDF, RDF (#5908) (#5911)

commit 9a1e91e
Author: ivanmaslow <165396466+ivanmaslow@users.noreply.github.com>
Date:   Wed Nov 6 14:54:14 2024 +0300

    #5915: Added two files, two tests, updated description (#5917)

commit 3a57f09
Author: aproskurnov <proskurn@gmail.com>
Date:   Wed Nov 6 11:39:28 2024 +0100

    Backmerge - #5833 Applied functional group drawing settings (#5883)

    * * applied functional group drawing settings

    * added micromolecules tests

    * added macromolecules tests

    * fixed bunch of micromol tests

    * fixed bunch of macromol tests

    * fixed micromolecule tests

    * fixed macro tests

    * fixed macromolecule tests

    * fixed micromolecule tests

    * fixed imports

    * fixed macro test

    * fixed micro tests

commit 7851c09
Author: Roman Rodionov <roman_rodionov@epam.com>
Date:   Wed Nov 6 10:54:25 2024 +0100

    #5873 - Export to ket (and getKET function) change incrementally internal IDs every call (#5916)

    - fixed monomer ids generation for serialization
    - updated test-data

commit eb5738f
Author: Nikita Chistousov <nikita_chistousov@epam.com>
Date:   Tue Nov 5 15:00:12 2024 +0100

    #5898 – Update indigo to 1.26.0-rc.1 in browser module (#5905)

    – updated indigo to 1.26.0-rc.1 in browser module
    - removed test which doesn't work

    ---------

    Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>

commit a691731
Author: Nikita Chistousov <nikita_chistousov@epam.com>
Date:   Mon Nov 4 12:28:53 2024 +0100

    Backmerge: #5809 – Open correct context menu for expanded monomer while clicking on bond or atom (#5901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aproskurnov aproskurnov

Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: High Team G User's Feedback
Projects
None yet
Milestone
Ketcher 2.26.0-rc.7
5 participants
@aproskurnov @NataliaLoginova @rrodionov91 @AlexeyGirin @AlekseiKhariukov