Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Antisense Strand option is enabled even if antisensless base present in chain selection #6088

Closed
AlexeyGirin opened this issue Dec 6, 2024 · 1 comment · Fixed by #6328
Closed

Create Antisense Strand option is enabled even if antisensless base present in chain selection #6088

AlexeyGirin opened this issue Dec 6, 2024 · 1 comment · Fixed by #6328
Assignees
@aproskurnov
Labels
Priority: High Severity: Low Low level visibility to the user Test Automation affected That issue affect on existed auto test, please update screenshots after fix
Milestone
Ketcher 3.1.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Dec 6, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macro - Snake mode
  2. Load from HELM using paste from clipboard: RNA1{R(A)P.[dR](A+C+G+U)P.R(A)P}$$$$V2.0
    image
  3. Select all monomers on the canvas and call context menu

Actual behavior
Create Antisense Strand option is enabled
image

If you pressed it - canvas become broken (selection feature stops working) and many exceptions at the console appear:
image

Expected behavior
Create Antisense Strand option is disabled
image

As per requirement:

1.1. If there is a sugar in the backbone and it is connected to the a base via R3-R1, but the base is not a "sense base" form the table above, the "Create Antisense Strand" option should appear, but be disabled.

Versions

  • Ketcher Version 2.28.0-rc.1 Build at 2024-12-03; 17:04:52
  • Indigo Version 1.27.0-rc.1.0-g8d656a341-wasm32-wasm-clang-19.0.0
  • Chrome Version 131.0.6778.109 (Official Build) (64-bit)
  • Win10

Issue found while testing - #5678
@AlexeyGirin AlexeyGirin added bug Priority: High Severity: Low Low level visibility to the user labels Dec 6, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.28.0-rc.2 milestone Dec 6, 2024
@AlexeyGirin AlexeyGirin changed the title Create Antisense Strand option is enabled even if antisensless base present in selection Create Antisense Strand option is enabled even if antisensless base present in chain selection Dec 6, 2024
@AlexeyGirin AlexeyGirin added the Test Automation affected That issue affect on existed auto test, please update screenshots after fix label Dec 17, 2024
@svvald svvald modified the milestones: Ketcher 2.28.0-rc.4, Ketcher 2.28.0-rc.5 Dec 25, 2024
@AlexeyGirin AlexeyGirin modified the milestones: Ketcher 2.28.0-rc.5, Ketcher 3.0.0-rc.2 Jan 9, 2025
@AlexeyGirin AlexeyGirin removed the bug label Jan 16, 2025
@aproskurnov aproskurnov self-assigned this Jan 20, 2025
@aproskurnov aproskurnov linked a pull request Jan 21, 2025 that will close this issue
#6088 disable create antisense strand option if antisensless base present in chain selection #6328
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Jan 22, 2025
@aproskurnov
#6088 disable create antisense strand option if antisensless base pre…
b393f7d 
…sent in chain selection (#6328)

* disable create antisense strand option

* added disabling menu for selection sugar

* added mixed type and base strand calculation
@AlexeyGirin
Copy link
Collaborator Author

Verified.
Image

  • Ketcher Version 3.0.0-rc.1 Build at 2025-01-28; 05:37:00
  • Indigo Version 1.29.0-dev.2.0-g4960b8ef-wasm32-wasm-clang-19.0.0
  • Chrome Version 132.0.6834.111 (Official Build) (64-bit)
  • Win10

@Drimodaren Drimodaren mentioned this issue Jan 28, 2025
Open
lmhs pushed a commit that referenced this issue Jan 29, 2025
@aproskurnov @lmhs
#6088 disable create antisense strand option if antisensless base pre…
30ca8ff 
…sent in chain selection (#6328)

* disable create antisense strand option

* added disabling menu for selection sugar

* added mixed type and base strand calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aproskurnov aproskurnov

Labels
Priority: High Severity: Low Low level visibility to the user Test Automation affected That issue affect on existed auto test, please update screenshots after fix
Projects
None yet
Milestone
Ketcher 3.1.0-rc.1
4 participants
@aproskurnov @svvald @rrodionov91 @AlexeyGirin