Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout in case of two sense chains connected to same antisense is wrong #6106

Closed
AlexeyGirin opened this issue Dec 9, 2024 · 1 comment · Fixed by #6374 or #6393
Closed

Layout in case of two sense chains connected to same antisense is wrong #6106

AlexeyGirin opened this issue Dec 9, 2024 · 1 comment · Fixed by #6374 or #6393
Assignees
@aproskurnov
Labels
Antisense Bucket: Antisense related issues Priority: Medium Severity: High High level visibility to the user Snake mode Bucket: Snake mode related issues User`s Feedback
Milestone
Ketcher 3.0.0-rc.7

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Dec 9, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macro - Snake mode
  2. Load from HELM using paste from clipboard: RNA1{R(A)P.R(C)P.R(G)P}|RNA2{R(T)P.R(C)P.R(C)P.R(C)P}|RNA3{R(C)P.R(C)P}$RNA1,RNA2,2:pair-2:pair|RNA3,RNA1,5:pair-8:pair$$$V2.0

Actual behavior
Layout goes wrong
image

Expected behavior
Layout goes correct (confirmed by @ljubica-milovic )
image

LONG CHAINS EXAMPLE:
image
LONG CHAINS EXAMPLE.zip

User's example:
image
ds testing.zip

Versions

  • Ketcher Version 2.28.0-rc.1 Build at 2024-12-03; 17:04:52
  • Indigo Version 1.27.0-rc.1.0-g8d656a341-wasm32-wasm-clang-19.0.0
  • Chrome Version 131.0.6778.109 (Official Build) (64-bit)
  • Win10

Issue found while testing - #5712
@AlexeyGirin AlexeyGirin added bug Priority: Medium Snake mode Bucket: Snake mode related issues Severity: Medium Medium level visibility to the user labels Dec 9, 2024
@AlexeyGirin AlexeyGirin added Severity: High High level visibility to the user User`s Feedback and removed Severity: Medium Medium level visibility to the user labels Dec 12, 2024
@svvald svvald modified the milestones: Ketcher 2.28.0-rc.4, Ketcher 2.28.0-rc.5 Dec 25, 2024
@AlexeyGirin AlexeyGirin modified the milestones: Ketcher 2.28.0-rc.5, Ketcher 3.0.0-rc.2 Jan 9, 2025
@AlexeyGirin AlexeyGirin removed the bug label Jan 16, 2025
@AlexeyGirin AlexeyGirin added the Antisense Bucket: Antisense related issues label Jan 24, 2025
@AlexeyGirin AlexeyGirin reopened this Jan 24, 2025
@AlexeyGirin AlexeyGirin reopened this Jan 24, 2025
@rrodionov91 rrodionov91 removed this from the Ketcher 3.0.0-rc.5 milestone Jan 28, 2025
@rrodionov91 rrodionov91 added this to the Ketcher 3.0.0-rc.6 milestone Jan 28, 2025
@aproskurnov aproskurnov linked a pull request Jan 30, 2025 that will close this issue
#6106 Two sense chain to one antisense connection render #6374
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Jan 30, 2025
@aproskurnov
#6106 Two sense chain to one antisense connection render (#6374)
599a441 
* fixed calcuation sense and antisense backbones

* mark antisense chain only if nucleotide

* removed unused function

* fixed shift complimentary chain even if not antisense connection

* returned back behaviour drop snake mode selection after reinitialization

* updated screenshots
aproskurnov added a commit that referenced this issue Jan 30, 2025
@aproskurnov
#6106 Two sense chain to one antisense connection render (#6374)
dbe09df 
* fixed calcuation sense and antisense backbones

* mark antisense chain only if nucleotide

* removed unused function

* fixed shift complimentary chain even if not antisense connection

* returned back behaviour drop snake mode selection after reinitialization

* updated screenshots
@aproskurnov aproskurnov mentioned this issue Jan 30, 2025
Merged
9 tasks
@aproskurnov aproskurnov linked a pull request Jan 30, 2025 that will close this issue
Backmerge: #6106 Two sense chain to one antisense connection render (#6374) #6393
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Jan 31, 2025
@aproskurnov
#6106 Two sense chain to one antisense connection render (#6374) (#6393)
7216044 
* fixed calcuation sense and antisense backbones

* mark antisense chain only if nucleotide

* removed unused function

* fixed shift complimentary chain even if not antisense connection

* returned back behaviour drop snake mode selection after reinitialization

* updated screenshots
@AlexeyGirin
Copy link
Collaborator Author

Verified.
Image

  • Ketcher Version 3.0.0-rc.7 Build at 2025-02-05; 16:27:42
  • Indigo Version 1.28.0-rc.3.0-gd5bcc27cb-wasm32-wasm-clang-19.0.0
  • Chrome Version 133.0.6943.54 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aproskurnov aproskurnov

Labels
Antisense Bucket: Antisense related issues Priority: Medium Severity: High High level visibility to the user Snake mode Bucket: Snake mode related issues User`s Feedback
Projects
None yet
Milestone
Ketcher 3.0.0-rc.7
4 participants
@aproskurnov @svvald @rrodionov91 @AlexeyGirin