Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System should not re-layout canvas in case of antisense creation #6132

Open
AlexeyGirin opened this issue Dec 11, 2024 · 2 comments · Fixed by #6396, #6467 or #6469
Open

System should not re-layout canvas in case of antisense creation #6132

AlexeyGirin opened this issue Dec 11, 2024 · 2 comments · Fixed by #6396, #6467 or #6469
Labels
Antisense Bucket: Antisense related issues Flex mode Bucket: Flex canvas related mode Priority: High Severity: High High level visibility to the user
Milestone
Ketcher 3.3.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Dec 11, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macro - Flex mode <---Important!
  2. Load from KET: System should not re-layout canvas in case of antisense creation.zip
    image
  3. Select bottom chain and create antisense chain for it
    image

Actual behavior
System re-layout canvas in the same way as Snake mode do
image

Expected behavior
Canvas layout should remain
image

Versions

  • Ketcher Version 2.28.0-rc.2 Build at 2024-12-10; 18:40:08
  • Indigo Version 1.27.0-rc.1.0-g8d656a341-wasm32-wasm-clang-19.0.0
  • Chrome Version 131.0.6778.140 (Official Build) (64-bit)
  • Win10

Issue found while testing - #5712
@AlexeyGirin AlexeyGirin added bug Priority: High Flex mode Bucket: Flex canvas related mode Severity: High High level visibility to the user labels Dec 11, 2024
@svvald svvald modified the milestones: Ketcher 2.28.0-rc.4, Ketcher 2.28.0-rc.5 Dec 25, 2024
@AlexeyGirin AlexeyGirin modified the milestones: Ketcher 2.28.0-rc.5, Ketcher 3.0.0-rc.2 Jan 9, 2025
@kostrubin kostrubin self-assigned this Jan 10, 2025
@AlexeyGirin AlexeyGirin removed the bug label Jan 16, 2025
@AlexeyGirin AlexeyGirin added the Antisense Bucket: Antisense related issues label Jan 24, 2025
kostrubin added a commit that referenced this issue Jan 31, 2025
@kostrubin
#6132 – System should not re-layout canvas in case of antisense creation
3588ae3
kostrubin added a commit that referenced this issue Jan 31, 2025
@kostrubin
#6132 - System should not re-layout canvas in case of antisense creation
fbead19
@kostrubin kostrubin linked a pull request Jan 31, 2025 that will close this issue
#6132 - System should not re-layout canvas in case of antisense creation #6396
Merged
9 tasks
@Zhirnoff Zhirnoff mentioned this issue Feb 7, 2025
Open
NataliaLoginova pushed a commit that referenced this issue Feb 7, 2025
@kostrubin
#6132 - System should not re-layout canvas in case of antisense creat…
ab248b1 
…ion (#6396)

* #6132 - System should not re-layout canvas in case of antisense creation

* set test to fail
kostrubin added a commit that referenced this issue Feb 10, 2025
@kostrubin
Backmerge: #6132 - System should not re-layout canvas in case of anti…
32a62c4 
…sense creation
@kostrubin kostrubin linked a pull request Feb 10, 2025 that will close this issue
Backmerge: #6132 - System should not re-layout canvas in case of antisense creation #6467
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Feb 10, 2025
@kostrubin
Backmerge: #6132 - System should not re-layout canvas in case of anti…
15e7447 
…sense creation (#6467)
kostrubin added a commit that referenced this issue Feb 10, 2025
@kostrubin
Backmerge: #6132 - System should not re-layout canvas in case of anti…
1a90455 
…sense creation
@kostrubin kostrubin linked a pull request Feb 10, 2025 that will close this issue
Backmerge: #6132 - System should not re-layout canvas in case of antisense creation #6469
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Feb 10, 2025
@kostrubin
Backmerge: #6132 - System should not re-layout canvas in case of anti…
c41ebde 
…sense creation (#6469)
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.

Image

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 131.0.6778.205 (Official Build) (64-bit)

Ketcher version
[Version 3.0.0-rc.8]
Indigo version
[Version 1.28.0-rc.3]

@rrodionov91 rrodionov91 reopened this Feb 19, 2025
@rrodionov91
Copy link
Collaborator

Reopened since revert changes in #6520

Previous fix was take last layout monomer position as the beginning for layout selected sense/antisense chains. Also it was still relate to end of viewport area(in 100% zoom) as the end position for each row. It leads to such incorrect layout:
Image

Proposal for new fix:
System should create antisense and apply layout only for chains selected for antisense creation. Layout start position should be the first monomer position in selection. Layout end position for each row should be startPosition.x + visible viewport area width(in 100% zoom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Antisense Bucket: Antisense related issues Flex mode Bucket: Flex canvas related mode Priority: High Severity: High High level visibility to the user
Projects
None yet
Milestone
Ketcher 3.3.0-rc.1
5 participants
@svvald @rrodionov91 @kostrubin @AlexeyGirin @Zhirnoff