Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3397 - When you save atom in ket format with substitutionCount great… #3398

Merged
merged 1 commit into from
Oct 5, 2023
Merged

#3397 - When you save atom in ket format with substitutionCount great… #3398

merged 1 commit into from
Oct 5, 2023

Conversation

AKZhuk
Copy link
Collaborator

@AKZhuk AKZhuk commented Oct 5, 2023 •
edited
Loading

…er then 6 , it is impossible to open it

  • Update schema.json
  • Fix hCount property

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@AKZhuk AKZhuk linked an issue Oct 5, 2023 that may be closed by this pull request
When you save atom in ket format with substitutionCount greater then 6 , it is impossible to open it #3397
Closed
@AKZhuk
#3397 - When you save atom in ket format with substitutionCount great…
3ebe5ca 
…er then 6 , it is impossible to open it

- Update schema.json
- Fix hCount property
@AKZhuk AKZhuk force-pushed the 3397-when-you-save-atom-in-ket-format-with-substitutioncount-greater-then-6-it-is-impossible-to-open-it branch from 5ee5082 to 3ebe5ca Compare October 5, 2023 13:16
This was referenced Oct 5, 2023
Closed
Closed
@AKZhuk AKZhuk requested review from ViktoriaTkacheva and y-holik and removed request for StarlaStarla October 5, 2023 13:28
@Nitvex Nitvex merged commit b22adf3 into master Oct 5, 2023
5 checks passed
@Nitvex Nitvex deleted the 3397-when-you-save-atom-in-ket-format-with-substitutioncount-greater-then-6-it-is-impossible-to-open-it branch October 5, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhirnoff Zhirnoff Zhirnoff approved these changes

@yuleicul yuleicul Awaiting requested review from yuleicul

@ViktoriaTkacheva ViktoriaTkacheva Awaiting requested review from ViktoriaTkacheva

@y-holik y-holik Awaiting requested review from y-holik

Assignees

@AKZhuk AKZhuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When you save atom in ket format with substitutionCount greater then 6 , it is impossible to open it
3 participants
@AKZhuk @Zhirnoff @Nitvex