#3431 – warnings appear while saving any structure as daylight smarts #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update fields max length for isotope and charge
- Update e2e snapshots
nanoblit
reviewed
Oct 13, 2023
| if (format === 'smarts') { | ||
| const arrayOfAtoms: Array<Atom> = Array.from(struct.atoms.values()); | ||
| const arrayOfBonds: Array<Bond> = Array.from(struct.bonds.values()); | ||
| console.log(arrayOfAtoms); |
nanoblit
approved these changes
Oct 13, 2023
nanoblit
reviewed
Oct 13, 2023
| atom.exactChangeFlag || | ||
| atom.invRet, | ||
| ); | ||
| const hasBondUnsupportedProperties = arrayOfBonds.some( |
There was a problem hiding this comment.
Maybe change these to something like "bondHasUnsupportedProperties", "atomHasUnsupportedProperties"? Would be more grammatically correct, but I'm not sure what the convention with has/is is on the project.
There was a problem hiding this comment.
or "bondsHaveUnsupportedProperties" since it's an array.
Zhirnoff
approved these changes
Oct 13, 2023
- Fix pr comments
Nitvex
changed the title
…rnings-appear-while-saving-any-structure-as-daylight-smarts
Nitvex
approved these changes
Oct 18, 2023
Nitvex
deleted the
3431-warnings-appear-while-saving-any-structure-as-daylight-smarts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name