Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro: #3041 – RNA Builder. Delete presets. #3473

Merged
merged 42 commits into from
Nov 10, 2023

Conversation

StarlaStarla
Copy link
Contributor

@StarlaStarla StarlaStarla commented Oct 20, 2023

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)
image
image

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@StarlaStarla StarlaStarla linked an issue Oct 20, 2023 that may be closed by this pull request
@StarlaStarla StarlaStarla force-pushed the 3041-rna-builder-delete-presets branch from 6c5f4e7 to 23edb07 Compare October 20, 2023 02:20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my computer this test regularly has error. Could you recheck it, please? I didn't find any problems there and it works in the app, but I am afraid that it could be flaky
Снимок экрана 2023-10-20 в 12 53 18

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. But after I merged the latest changes from master and rebuild the project, it could always run successfully.

@StarlaStarla StarlaStarla force-pushed the 3041-rna-builder-delete-presets branch from ba4202f to 5233d64 Compare November 9, 2023 06:03
@Nitvex Nitvex changed the title #3041 - Macro: RNA Builder. Delete presets. Macro: #3041 – RNA Builder. Delete presets. Nov 9, 2023
@rrodionov91 rrodionov91 merged commit 80bc156 into master Nov 10, 2023
5 checks passed
@rrodionov91 rrodionov91 deleted the 3041-rna-builder-delete-presets branch November 10, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro: RNA Builder. Delete presets.
6 participants