Macro: #3635 - Misalignment of monomers when imposing on top of each other #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chgayane
changed the title
…dinates order for consistency with the function
auto-assign
bot
requested review from
Nitvex,
StarlaStarla and
ViktoriaTkacheva
…cro-misalignment-of-monomers-when-imposing-on-top-of-each-other
…cro-misalignment-of-monomers-when-imposing-on-top-of-each-other
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…cro-misalignment-of-monomers-when-imposing-on-top-of-each-other
packages/ketcher-core/src/domain/helpers/attachmentPointCalculations.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-core/src/domain/helpers/attachmentPointCalculations.ts
Outdated
Show resolved
Hide resolved
StarlaStarla
approved these changes
Dec 13, 2023
Nitvex
approved these changes
Dec 13, 2023
Nitvex
deleted the
3635-macro-misalignment-of-monomers-when-imposing-on-top-of-each-other
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Before: The attachment points of the underlying monomer become scattered, resulting in distorted monomers and misalignment.
After: The attachment points should remain intact, and the monomers should align correctly without scattering or distortion.
Updated the logic used to find the point on the monomer border. Replaced
document.elementFromPointwithdocument.elementsFromPointto accurately handle overlapping monomers. Added additional type checks to cater to 'null' conditions. This change resolves issues related to incorrect border point and angle calculation when monomers overlap.Check list
#1234 – issue name