Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge: #4297 - Macro: When removing nucleotides from the canvas, the preview of the nucleotide does not disappear, if you leave the cursor over it #4312

Merged

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Mar 21, 2024

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

… of the nucleotide does not disappear, if you leave the cursor over it

- added removing preview on mousemove and keypress
- added getting canvas and canvasWrapper from ZoomTool to find it in DOM once instead of on each renderer creation
- added async rendering after each keypress event handled in sequence edit mode
@rrodionov91 rrodionov91 merged commit 493e920 into master Mar 22, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 4297-sequence-edit-preview-not-disappear-backmerge branch March 22, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants