Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4708 – Forbid merging cyclic sequences on delete in Sequence mode #4768

Conversation

svvald
Copy link
Collaborator

@svvald svvald commented Jun 6, 2024

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

rrodionov91 and others added 8 commits June 4, 2024 16:33
- fixed position calculation for external bonds to sgroups without attachment points
… flex to sequence (#4736)

- added removing of copy/paste event listeners during switching between micro/macro modes
…l in micro mode (#4737)

- unblocked monomers deletion in micro mode
…of Flex modes and switch through modes (#4753)

* #4690 - Undo problem while layout is changed on the Snack of Flex modes and switch through modes

- prevented layout to be called if turn on snake mode by undo operation
- changed move to redraw for polymerBonds in DrawingEntityMoveOperation

* #4333 - Macro: Bonds detach when moving monomers in a snake mode in Playwright autotests

- updated screenshots
…e indication (#4759)

- fixed ZoomControls component subscription to ZoomTool instance
- removed error on ketcher side if format was not detected
@svvald svvald changed the base branch from master to release/2.22 June 6, 2024 09:27
@svvald svvald closed this Jun 6, 2024
@svvald svvald deleted the 4708-when-merging-two-cyclic-sequences-in-the-sequence-mode-they-disappear-from-the-canvas branch June 6, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When merging two cyclic sequences in the Sequence mode, they disappear from the canvas
3 participants