#5990 – Extend Ketcher API to allow updating monomers library #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
NataliaLoginova,
rrodionov91 and
Zhirnoff
svvald
force-pushed
the
5990-extend-ketcher-api-with-a-function-to-update-monomers-library
branch
from
2f8753f to
8185dac
Compare
…ate API docs in README
svvald
force-pushed
the
5990-extend-ketcher-api-with-a-function-to-update-monomers-library
branch
from
e8de89e to
97a27ba
Compare
rrodionov91
approved these changes
Dec 2, 2024
| existingMonomerRefIndex | ||
| ]; | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| delete this._monomersLibraryParsedJson![existingMonomerIdToUse]; |
There was a problem hiding this comment.
I think it's better to write
if (!this._monomersLibraryParsedJson) {
return
}
Than use several times non-null assertion
|
|
||
| if (!editor) { | ||
| throw new Error( | ||
| 'Updating monomer library in small molecules mode is not allowed, please switch to macromolecules mode', |
There was a problem hiding this comment.
We can store libraries somewhere and use them on macro mode initialization stage
| public updateMonomersLibrary(rawMonomersData: string | JSON) { | ||
| const editor = CoreEditor.provideEditorInstance(); | ||
|
|
||
| ketcherProvider.getKetcher(); |
There was a problem hiding this comment.
Why do we need this call?
Comment on lines
+70
to
+72
| let persistentMonomersLibrary: MonomerItemType[] = []; | ||
| let persistentMonomersLibraryParsedJson: IKetMacromoleculesContent | null = | ||
| null; |
There was a problem hiding this comment.
Probably we can allow to call api several times and update library several times consequently? In this case we need to store array of libraries
svvald
deleted the
5990-extend-ketcher-api-with-a-function-to-update-monomers-library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name