Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes w.r.t. LeGO-LOAM #9

Closed
robot54 opened this issue Apr 11, 2020 · 1 comment
Closed

Minor changes w.r.t. LeGO-LOAM #9

robot54 opened this issue Apr 11, 2020 · 1 comment

Comments

@robot54
Copy link

robot54 commented Apr 11, 2020

Hi @yzrobot,

Thank you for this dataset and the related Lidar odometry methods.

I'm applying the original version of LeGO-LOAM on your dataset (by 'original' I mean the version available via https://github.com/RobustFieldAutonomyLab/LeGO-LOAM). And I would like to know if you modified something in the code before getting the trajectory's figures based on the topic /aft_mapped_to_init.

In my humble opinion, in the original version of LeGO-LOAM at least, I think that the topic containing the final trajectory estimation is rather /key_pose_origin than /aft_mapped_to_init.
In attachment, you find a figure of both the poses contained in /key_pose_origin and /aft_mapped_to_init. The trajectories are very similar, except after the detection of a loop closure. There, /aft_mapped_to_init seems to "jump" until the correct pose without updating the previous poses, while /key_pose_origin seems to update all poses.

EU_LL_issue_1

EU_LL_issue_2

I would be happy to know your opinion about this. Don't hesitate to tell me what you think.

Have a nice day.

@yzrobot
Copy link
Contributor

yzrobot commented Apr 12, 2020

Hi,

Many thanks for pointing this out! We actually very much welcome community contributions and really appreciate it. We have linked your contribution to README to better help the community.

Best.

@yzrobot yzrobot closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants