Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vignette comparing with {finalsize} #128

Merged
merged 18 commits into from
Oct 25, 2023
Merged

Conversation

pratikunterwegs
Copy link
Collaborator

@pratikunterwegs pratikunterwegs commented Oct 9, 2023

This PR fixes #33.

@github-actions
Copy link

This pull request:

  • Adds 5 new dependencies (direct and indirect)
  • Adds 2 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(cc @Bisaloo for workflow monitoring)

1 similar comment
@github-actions
Copy link

This pull request:

  • Adds 5 new dependencies (direct and indirect)
  • Adds 2 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(cc @Bisaloo for workflow monitoring)

@pratikunterwegs pratikunterwegs marked this pull request as ready for review October 12, 2023 09:49
@adamkucharski
Copy link
Member

Thanks for sharing. I think we need to do more to make it really clear up front in the opening paragraph what the reader will get out of this vignette (especially as we'll likely have quite a few for this package, and need to help users know which ones most relevant).

It seems that the two main areas of comparison to frame the piece around are:

  1. Which tasks sit best in finalsize and epidemics, and how to switch between (e.g. if user has a finalsize model that implicitly assumes vaccination upfront but wants to convert into an epidemics model to explore roll out, or epidemics model but wants to simplify for computational speed)
  2. Relative speed, and context. For one off simulations, fractional differences of a second won't make much difference, so could give example for context - e.g. if do a simple 1000 value parameter sweep on R0, how long would final size take can epidemics?

For me, the numerical accuracy comparisons are least relevant here, because already explored in finalsize documentation, and could be confusing to include mix comparison with different model structures and solver methods (and beyond scope of interest for most target users of this package).

@pratikunterwegs
Copy link
Collaborator Author

Thanks - I'll do some restructuring over the next few days to focus on those points.

@github-actions
Copy link

This pull request:

  • Adds 7 new dependencies (direct and indirect)
  • Adds 2 new system dependencies
  • Removes 1 existing dependencies (direct and indirect)
  • Removes 1 existing system dependencies

(cc @Bisaloo for workflow monitoring)

@github-actions
Copy link

This pull request:

  • Adds 7 new dependencies (direct and indirect)
  • Adds 2 new system dependencies
  • Removes 1 existing dependencies (direct and indirect)
  • Removes 1 existing system dependencies

(cc @Bisaloo for workflow monitoring)

@pratikunterwegs
Copy link
Collaborator Author

Made some changes to this vignette to highlight different use cases for finalsize and epidemics, hopefully this is more useful @adamkucharski? Happy to incorporate more feedback.

@github-actions
Copy link

This pull request:

  • Adds 7 new dependencies (direct and indirect)
  • Adds 2 new system dependencies
  • Removes 1 existing dependencies (direct and indirect)
  • Removes 1 existing system dependencies

(cc @Bisaloo for workflow monitoring)

@github-actions
Copy link

This pull request:

  • Adds 5 new dependencies (direct and indirect)
  • Adds 2 new system dependencies
  • Removes 1 existing dependencies (direct and indirect)
  • Removes 1 existing system dependencies

(cc @Bisaloo for workflow monitoring)

@pratikunterwegs pratikunterwegs merged commit e4deaf4 into main Oct 25, 2023
12 checks passed
@pratikunterwegs pratikunterwegs deleted the finalsize_vignette branch October 25, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vignette to compare with {finalsize}
4 participants