-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vignette comparing with {finalsize} #128
Conversation
b909a65
to
2d7f977
Compare
This pull request:
(cc @Bisaloo for workflow monitoring) |
1 similar comment
This pull request:
(cc @Bisaloo for workflow monitoring) |
Thanks for sharing. I think we need to do more to make it really clear up front in the opening paragraph what the reader will get out of this vignette (especially as we'll likely have quite a few for this package, and need to help users know which ones most relevant). It seems that the two main areas of comparison to frame the piece around are:
For me, the numerical accuracy comparisons are least relevant here, because already explored in finalsize documentation, and could be confusing to include mix comparison with different model structures and solver methods (and beyond scope of interest for most target users of this package). |
Thanks - I'll do some restructuring over the next few days to focus on those points. |
This pull request:
(cc @Bisaloo for workflow monitoring) |
This pull request:
(cc @Bisaloo for workflow monitoring) |
Made some changes to this vignette to highlight different use cases for finalsize and epidemics, hopefully this is more useful @adamkucharski? Happy to incorporate more feedback. |
This pull request:
(cc @Bisaloo for workflow monitoring) |
d32f456
to
f7affcd
Compare
This pull request:
(cc @Bisaloo for workflow monitoring) |
This PR fixes #33.