Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette on parameter uncertainty #131

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Conversation

pratikunterwegs
Copy link
Collaborator

@pratikunterwegs pratikunterwegs commented Oct 12, 2023

This PR is related to #20 and adds a vignette initially authored by @adamkucharski showing how to use {EpiEstim} to generate an $R$ estimate, and how to run multiple iterations of epidemic_default_*() for different $R$ values.

This PR is scheduled be merged after #128.

@pratikunterwegs
Copy link
Collaborator Author

Hi @adamkucharski - I've drafted this PR from your branch on $R_0$ uncertainty, are you happy for me to get it passing checks and merge it, or would you like to continue developing it? No rush either way.

@adamkucharski
Copy link
Member

Thanks. One thing that would be useful to add is a plot of outcomes in the final section of the vignette, e.g. showing the trajectories of cases from the output_samples array across different sampled R0 values (didn't have time on the day to find neatest way of wrangling into ggplot!)

@pratikunterwegs
Copy link
Collaborator Author

Thanks. One thing that would be useful to add is a plot of outcomes in the final section of the vignette, e.g. showing the trajectories of cases from the output_samples array across different sampled R0 values (didn't have time on the day to find neatest way of wrangling into ggplot!)

Thanks, can definitely do! Will tag you again once it's complete.

@github-actions
Copy link

This pull request:

  • Adds 16 new dependencies (direct and indirect)
  • Adds 2 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(cc @Bisaloo for workflow monitoring)

@pratikunterwegs pratikunterwegs self-assigned this Oct 20, 2023
@pratikunterwegs pratikunterwegs added the Documentation Improvements or additions to documentation label Oct 20, 2023
@github-actions
Copy link

This pull request:

  • Adds 16 new dependencies (direct and indirect)
  • Adds 2 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(cc @Bisaloo for workflow monitoring)

@pratikunterwegs pratikunterwegs marked this pull request as ready for review October 20, 2023 15:06
Copy link
Member

@adamkucharski adamkucharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very nice – good starting example that should open doors for a lot of useful scenario analysis work. Only a couple of minor comments.

vignettes/parameter_uncertainty.Rmd Show resolved Hide resolved
vignettes/parameter_uncertainty.Rmd Show resolved Hide resolved
@github-actions
Copy link

This pull request:

  • Adds 16 new dependencies (direct and indirect)
  • Adds 2 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(cc @Bisaloo for workflow monitoring)

@pratikunterwegs
Copy link
Collaborator Author

This is looking very nice – good starting example that should open doors for a lot of useful scenario analysis work. Only a couple of minor comments.

Great, thanks for the feedback, merging this now.

@pratikunterwegs pratikunterwegs merged commit 0a9b5a6 into main Oct 25, 2023
11 checks passed
@pratikunterwegs pratikunterwegs deleted the parameter-distributions branch October 25, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants