-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource workflow + page #241
Conversation
✅ Deploy Preview for tourmaline-marshmallow-241b40 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great!
An additional feature request, I'll leave it up to you to decide if it should make it in the MVP, or turned into a follow up issue: I would love to have the ability to select a combination of tags. E.g., "testing" and "APIs", which would make it easier to find resource such as https://books.ropensci.org/http-testing/index.html.
@@ -14,13 +14,15 @@ website: | |||
href: get-involved.qmd | |||
- text: Blog | |||
menu: | |||
- text: All |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be something like "all blog posts" or something? Because it doesn't include presentations, i.e., not all publications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the confusion - I moved the presentations back into the main bar for now and will come with a proposal. May also be helped by the multi-selection you mentioned (which is tracked over in #244).
This PR adds a resource page and workflow. This builds on the work from #234 and does the following:
./resources/<id>.qmd
, with a YAML header containing the relevant metadata. Included metadata at this time:./resources/
on the/resources
page, displaying the upvote count, date added, and all categoriesGiven that the resources section on the forum is still empty, it currently will look empty upon merge. I add a video for display purposes:
Screen.Recording.2024-04-29.at.18.36.15.mov
I am pretty pleased I was able to set all of this up - and excited to hear your thoughts! Of course there's plenty of room for improvement, so looking forward to the feedback 😊