Strictnullchecks 1 #1140
Merged
Strictnullchecks 1 #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/components/app-overview/index.tsx # src/components/async-resource/async-resource.tsx # src/components/component/dns-aliases.tsx # src/components/create-job-form/index.tsx # src/components/create-job-form/pipeline-form-build-branches.tsx # src/components/create-job-form/use-get-application-branches.ts # src/components/environments-summary/environment-ingress.tsx # src/components/environments-summary/index.tsx # src/components/page-configuration/index.tsx
satr
reviewed
Nov 29, 2024
| ended, | ||
| }) => { | ||
| type DurationProps = { started: Date; ended?: Date }; | ||
| const ReplicaDuration = ({ started, ended }: DurationProps) => { |
There was a problem hiding this comment.
Replica started is another field startTime. So technically it is created
For component
func GetReplicaSummary(pod corev1.Pod, lastEventWarning string) ReplicaSummary {
...
creationTimestamp := pod.GetCreationTimestamp()
replicaSummary.Created = radixutils.FormatTimestamp(creationTimestamp.Time)
For job pod
func GetReplicaSummaryByJobPodStatus(radixBatchJob radixv1.RadixBatchJob, jobPodStatus radixv1.RadixBatchJobPodStatus) models.ReplicaSummary {
summary := models.ReplicaSummary{
Name: jobPodStatus.Name,
Created: utils.FormatTimestamp(jobPodStatus.CreationTime.Time),
...
}
if jobPodStatus.StartTime != nil {
summary.StartTime = utils.FormatTimestamp(jobPodStatus.StartTime.Time)
There was a problem hiding this comment.
Hmm, I see what you mean, but wanted all the Duration components to have the same API, and felt that it didn't need to know anything about replica status or where its used :)
satr
reviewed
Nov 29, 2024
satr
reviewed
Nov 29, 2024
Co-authored-by: Sergey Smolnikov <ssmol@equinor.com>
Co-authored-by: Sergey Smolnikov <ssmol@equinor.com>
satr
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.