Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate webvizstore calls #505

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Remove duplicate webvizstore calls #505

merged 1 commit into from
Nov 30, 2020

Conversation

HansKallekleiv
Copy link
Collaborator

@HansKallekleiv HansKallekleiv commented Nov 27, 2020 •
edited
Loading

Combine the the webvizstore decorated function for load_smry in one centralized place

Contributor checklist

  • 🎉 This PR closes Repeated calls to load_smry() decreases performance #506.
  • 📜 I have broken down my PR into the following tasks:
    • Move the EnsembleSetModel class to _models and create new class EnsembleModel to handle loading of ensemble data.
    • Use these classes in all relevant plugins to load smry data
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@HansKallekleiv HansKallekleiv force-pushed the centralize-store-functions branch 3 times, most recently from a729980 to 6b80ef9 Compare November 27, 2020 18:18
@asnyv asnyv self-requested a review November 28, 2020 14:31
@asnyv asnyv force-pushed the centralize-store-functions branch from 68db28f to e58cc70 Compare November 28, 2020 19:07
@HansKallekleiv HansKallekleiv force-pushed the centralize-store-functions branch 3 times, most recently from 7eaef1e to dcdf31a Compare November 30, 2020 08:51
@HansKallekleiv HansKallekleiv force-pushed the centralize-store-functions branch from 74889db to 39582d3 Compare November 30, 2020 14:01
@HansKallekleiv HansKallekleiv merged commit 5c1192b into equinor:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnyv asnyv asnyv left review comments

@anders-kiaer anders-kiaer anders-kiaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repeated calls to load_smry() decreases performance
3 participants
@HansKallekleiv @anders-kiaer @asnyv