Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParameterAnalysis: Allow initialization without field vectors #599

Merged
merged 1 commit into from
Mar 26, 2021
Merged

ParameterAnalysis: Allow initialization without field vectors #599

merged 1 commit into from
Mar 26, 2021

Conversation

HansKallekleiv
Copy link
Collaborator

@HansKallekleiv HansKallekleiv commented Mar 24, 2021 •
edited
Loading

Fixed issue in Parameteranalysis when no Field vectors were available.

Contributor checklist

  • 🎉 This PR closes ParameterAnalysis plugin requires a FIELD vector #591.
  • 📜 I have broken down my PR into the following tasks:
    • Allow initialization of plugin with no Field vectors
    • Changed view and controller function arguments to be more specific instead of parsing the whole plugin class.
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@HansKallekleiv HansKallekleiv requested a review from tnatt March 24, 2021 14:07
@HansKallekleiv HansKallekleiv force-pushed the fix-vector-parameter-analysis branch from 2f8e27e to c2db064 Compare March 24, 2021 14:15
tnatt
tnatt approved these changes Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HansKallekleiv HansKallekleiv force-pushed the fix-vector-parameter-analysis branch from c5b0229 to d015619 Compare March 26, 2021 09:45
@HansKallekleiv HansKallekleiv merged commit b6303fc into equinor:master Mar 26, 2021
@HansKallekleiv HansKallekleiv deleted the fix-vector-parameter-analysis branch March 26, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@tnatt tnatt tnatt approved these changes

@asnyv asnyv Awaiting requested review from asnyv

Assignees
No one assigned
Labels
None yet
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ParameterAnalysis plugin requires a FIELD vector
3 participants
@HansKallekleiv @anders-kiaer @tnatt