Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreventUpdate in ReservoirSimulationTimeSeries download callback if not data_requested #602

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

asnyv
Copy link
Collaborator

@asnyv asnyv commented Mar 25, 2021

No reason to do the calculation at initialisation. Also necessary as follow-up to webviz-core-components/#99 (though that could also be solved by returning None rather than "" when data is not requested).

Contributor checklist

  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@asnyv asnyv force-pushed the nodatarequested branch from 78b7533 to c4ae7fd Compare March 25, 2021 13:50
@asnyv asnyv marked this pull request as ready for review March 25, 2021 13:51
@asnyv asnyv changed the title PreventUpdate in download callback if not data_requested PreventUpdate in ReservoirSimulationTimeSeries download callback if not data_requested Mar 25, 2021
@asnyv asnyv merged commit 77d7384 into equinor:master Mar 25, 2021
@asnyv asnyv deleted the nodatarequested branch March 25, 2021 14:55
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
* New grid layer

* Lint fix

* Added example data

* Test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants