-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WellCompletion plugin #610
Conversation
…ded zone layer input to webvizstore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @lindjoha 🎉 🚀 👏 Some initial feedback on first review - mostly small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Minor comments only.
Two suggestions in addition to those below:
- You can change these env.variables temporarily to
lindjoha
andwellcompletions_testdata
respectively. Then the CI tests will run towards the soon-to-be-added testdata.
webviz-subsurface/.github/workflows/subsurface.yml
Lines 74 to 79 in 91226ff
# If you want the CI to (temporarily) run against your fork of the testdada, # change the value her from "equinor" to your username. TESTDATA_REPO_OWNER: equinor # If you want the CI to (temporarily) run against another branch than master, # change the value her from "master" to the relevant branch name. TESTDATA_REPO_BRANCH: master - Add a "tour" to the plugin (the "?" button we have on the advanced plugins), explaining what the user is looking at.
Agreed on this format. |
New plugin WellCompletion for visualizing COMPDAT data from Eclipse.
There are three data sources to this plugin meant to be exported by the FMU workflow:
The plugin aggregates the data to a given format that is passed to the WellCompletions component in webviz-subsurface-components.
Contributor checklist
CHANGELOG.md
, and added it if should be communicated there.