Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WellCompletion plugin #610

Merged
merged 39 commits into from
Apr 27, 2021
Merged

Conversation

lindjoha
Copy link
Collaborator

@lindjoha lindjoha commented Apr 22, 2021

New plugin WellCompletion for visualizing COMPDAT data from Eclipse.

There are three data sources to this plugin meant to be exported by the FMU workflow:

  • a csv file with compdat data
  • a lyr file with zone->layer mapping (optional)
  • a json file with well attributes (optional)

The plugin aggregates the data to a given format that is passed to the WellCompletions component in webviz-subsurface-components.

Contributor checklist

  • 🎉 This PR closes Well completion plugin (Equinor) #585
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

Øyvind Lind-Johansen (PTC MOD MN) and others added 28 commits April 6, 2021 20:38
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @lindjoha 🎉 🚀 👏 Some initial feedback on first review - mostly small comments.

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Minor comments only.

Two suggestions in addition to those below:

  • You can change these env.variables temporarily to lindjoha and wellcompletions_testdata respectively. Then the CI tests will run towards the soon-to-be-added testdata.
    # If you want the CI to (temporarily) run against your fork of the testdada,
    # change the value her from "equinor" to your username.
    TESTDATA_REPO_OWNER: equinor
    # If you want the CI to (temporarily) run against another branch than master,
    # change the value her from "master" to the relevant branch name.
    TESTDATA_REPO_BRANCH: master
  • Add a "tour" to the plugin (the "?" button we have on the advanced plugins), explaining what the user is looking at.

@lindjoha
Copy link
Collaborator Author

{
    "units": {
        "kh":{
            "unit":"mDm",
            "decimal_places":2
        }
    }
    "stratigraphy": [
           ...

Agreed on this format.

@anders-kiaer anders-kiaer merged commit 2427301 into equinor:master Apr 27, 2021
@lindjoha lindjoha deleted the wellcomp_plugin_v2 branch May 18, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Well completion plugin (Equinor)
2 participants