Including stratigraphy in the well completion plugin #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindjoha
requested review from
anders-kiaer,
asnyv and
HansKallekleiv
as code owners
anders-kiaer
requested changes
May 21, 2021
There was a problem hiding this comment.
I think we are close to be able to merge this 👍 🚀
In addition to the comments above, it might be worth adding a changelog entry in CHANGELOG.md and bumping the lower level version constraint on ecl2df in setup.py (since we depend on new functionality in that dependency). 🙂
added 2 commits
May 24, 2021 20:39
…ing about not seing lumped completions being closed.
anders-kiaer
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR is the possibility to pass a json file with a stratigraphic tree to the plugin. The stratigraphy will be combined with the zone_layer mapping file (lyr-file) to generate the final stratigraphy that is passed to the wsc component.
There is also new logic around colors. Colors can be supplied through both the stratigraphy file and the lyr file. If colors is passed in both files, the stratigraphy has priority. If no colors is passed, the theme colors will be used. The parsing of the lyr files with colors is depending on new functionality in ecl2df.
There is a file with tests around the logic of the above.
There is also some new functionality around the kh units. If now kh unit is supplied, the plugin will look in the eclipse DATA file for the unit system, and choose the correct unit according to that.