Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle operations between surfaces of different topology #666

Merged
merged 2 commits into from
Jun 11, 2021

Conversation

HansKallekleiv
Copy link
Collaborator

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.


Contributor checklist

@jcrivenaes
Copy link
Collaborator

This should already be handled autmatically in xtgeo if you take operations between instances:
Let s1 and s2 be two RegularSurface() instances, then e.g.

diff = s1 - s2

shall regrid s2 to the topology of s1 behind the scene. See https://github.com/equinor/xtgeo/blob/ab3d188da03f100df65a62449473cccce5e43b5f/src/xtgeo/surface/_regsurf_oper.py#L44

@HansKallekleiv
Copy link
Collaborator Author

This should already be handled autmatically in xtgeo if you take operations between instances:
Let s1 and s2 be two RegularSurface() instances, then e.g.

diff = s1 - s2

shall regrid s2 to the topology of s1 behind the scene. See https://github.com/equinor/xtgeo/blob/ab3d188da03f100df65a62449473cccce5e43b5f/src/xtgeo/surface/_regsurf_oper.py#L44

Thanks @jcrivenaes . Changed code to do operations between instances.

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HansKallekleiv HansKallekleiv merged commit a145dc7 into equinor:master Jun 11, 2021
@HansKallekleiv HansKallekleiv deleted the surface-operations branch June 11, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Calculations between surfaces with different topology fails in SurfaceViewerFMU
3 participants