Tornado improvements #676
Merged
Tornado improvements #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKallekleiv
force-pushed
the
tornado-fixes
branch
2 times, most recently
from
eccf2dc to
4640386
Compare
anders-kiaer
approved these changes
Jun 23, 2021
Comment on lines
+3
to
+4
| import pandas as pd | ||
| import plotly.graph_objects as go |
There was a problem hiding this comment.
Suggested change
| import pandas as pd | |
| import plotly.graph_objects as go | |
| import pandas as pd | |
| import plotly.graph_objects as go | |
| @property | ||
| def scatter_data(self) -> List[Dict]: | ||
| return [ | ||
| dict( |
There was a problem hiding this comment.
I think we elsewhere mostly use {key: value} and not dict(key= value).
HansKallekleiv
force-pushed
the
tornado-fixes
branch
2 times, most recently
from
b471e29 to
c83cc8c
Compare
HansKallekleiv
force-pushed
the
tornado-fixes
branch
from
c83cc8c to
3a75747
Compare
VincentNevermore
pushed a commit
to VincentNevermore/webviz-subsurface
that referenced
this pull request
Jul 19, 2022
Also added reference to deck.gl documentation. Partial fix for equinor#292. Co-authored-by: Havard Bjerke <havard.bjerke@emerson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert a description of your pull request (PR) here, and check off the boxes below when they are done.
Contributor checklist
CHANGELOG.md, and added it if should be communicated there.