Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tornadoplots, and further improvements to VolumetricAnalysis #681

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Tornadoplots, and further improvements to VolumetricAnalysis #681

merged 1 commit into from
Jun 24, 2021

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Jun 24, 2021 •
edited
Loading

Various improvement to the VolumetricAnalysis plugin.

  • Added page with tornadoplots for sensitivity runs
  • Added function in InplaceVolumesModel to retrieve dataframe. The function handles filtering, grouping of the data and addition of parameters. This removed a lot of logic from the callbacks in the VolumetricAnalysis plugin.
  • Possible computation of NTG from facies if non_net _facies are set in the config
  • Automatic computation of water zone volumes if total volumes are included
  • Improved callback logic by separating selections/filters by tab.
  • Added "bar" as plot type option
  • Raise exception if selectors are defined for all sources.
  • Changed to the new layout components in webviz-core-components

Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@anders-kiaer anders-kiaer added next release 🚢 To be included in next release enhancement 🚀 New feature or request labels Jun 24, 2021
anders-kiaer
anders-kiaer requested changes Jun 24, 2021
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 Only minor suggestions.

@HansKallekleiv HansKallekleiv merged commit 9cb8764 into equinor:master Jun 24, 2021
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
@shruthirai
Horizontal and verical layout options for color legends (equinor#681)
6445827 
* Horizontal and verical layout options for color legends

* Assigning dynamic height and width

* Fix height and width

* Fix lint error

Co-authored-by: Shruthi Rai <shruthi.rai@emerson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansKallekleiv HansKallekleiv HansKallekleiv approved these changes

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@asnyv asnyv Awaiting requested review from asnyv

Assignees

@tnatt tnatt

Labels
enhancement 🚀 New feature or request next release 🚢 To be included in next release
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnatt @HansKallekleiv @anders-kiaer