Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Well log viewer #733

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Well log viewer #733

merged 2 commits into from
Aug 24, 2021

Conversation

HansKallekleiv
Copy link
Collaborator

Contributor checklist

  • 🎉 This PR closes Well log viewer #732. closes Log export on Python side (for usage in new React log viewer component) #731.
  • 📜 I have broken down my PR into the following tasks:
    • Adjust roxar2json code for converting RMS well data to json to use xtgeo format.
    • Define a format to specify log template as input configuration
    • Make plugin using the WellLogViewer component in webviz-subsurface-components.
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@HansKallekleiv HansKallekleiv marked this pull request as draft August 16, 2021 12:27
@HansKallekleiv HansKallekleiv added the next release 🚢 To be included in next release label Aug 23, 2021
@anders-kiaer anders-kiaer marked this pull request as ready for review August 24, 2021 11:54
anders-kiaer
anders-kiaer requested changes Aug 24, 2021
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Worth a changelog entry 🎉

@HansKallekleiv HansKallekleiv force-pushed the well-log-viewer branch 2 times, most recently from 4229d7a to c5ac32a Compare August 24, 2021 12:27
@HansKallekleiv HansKallekleiv merged commit 07d4c55 into equinor:master Aug 24, 2021
@HansKallekleiv HansKallekleiv deleted the well-log-viewer branch August 24, 2021 18:00
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
@hkfb
Promoted jsverify to production dependency. (equinor#733)
e1f1232 
Fixes equinor#716.

Co-authored-by: Havard Bjerke <havard.bjerke@emerson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@asnyv asnyv Awaiting requested review from asnyv

@tnatt tnatt Awaiting requested review from tnatt

Assignees

@HansKallekleiv HansKallekleiv

Labels
next release 🚢 To be included in next release
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Well log viewer Log export on Python side (for usage in new React log viewer component)
2 participants
@HansKallekleiv @anders-kiaer