Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for drogon #755

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

HansKallekleiv
Copy link
Collaborator

@HansKallekleiv HansKallekleiv commented Sep 1, 2021

Some of the tests uses data from webviz-subsurface-testdata.
This PR implements the necessary changes to make the tests run with the new Drogon dataset that will be added in equinor/webviz-subsurface-testdata#86.

Two selenium tests that created a portable app was removed.

Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Update current tests to use the Drogon dataset
    • Remove 2 integration tests that built a portable app.
    • Added individual selenium test for each plugin
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@HansKallekleiv HansKallekleiv force-pushed the fix-test-for-drogon branch 4 times, most recently from ef95bf6 to 9fe096a Compare September 6, 2021 13:40
@HansKallekleiv HansKallekleiv merged commit 895455e into equinor:master Sep 7, 2021
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
* Importing continuous legend code from colortable repo

* Update deckgl-map-spec.json

* Update deckgl-map.json

* Code Refactor

* Code refactor

* Solving lint error

Co-authored-by: Shruthi Rai <shruthi.rai@emerson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants