Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seismic misfit improvements #844

Merged
merged 7 commits into from
Nov 12, 2021
Merged

Conversation

rnyb
Copy link
Collaborator

@rnyb rnyb commented Nov 10, 2021

General improvements


Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Reworked all colors. Use same symmetric colorscale for all types of attributes. Also new color scales for diff plot and error plot. Colorscales are included as global variables.
    • Prettyfied all hoverdata
    • New option for slice plot. show individual realizations
    • Keep user defined zoom during callback
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@rnyb rnyb added the enhancement 🚀 New feature or request label Nov 10, 2021
@rnyb rnyb self-assigned this Nov 10, 2021
@rnyb rnyb requested review from asnyv and tnatt as code owners November 10, 2021 13:32
@rnyb rnyb mentioned this pull request Nov 10, 2021
11 tasks
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment - otherwise LGTM.

@rnyb rnyb requested a review from anders-kiaer November 11, 2021 14:33
@rnyb rnyb force-pushed the seismic-misfit-improvements branch from 8592dfb to c8d5881 Compare November 11, 2021 14:51
rnyb added 7 commits November 12, 2021 09:21
For the polygon, the multi select option is now set to False as it
caused issues with combining multiple polygon-files. Also set initial
polygon value to empty for slightly better performance at start-up.
Map view layout/zoom persists during callbacks (keep user settings).
Map view zoom consistent throughout subplots.
Map plot pan works in all directions for subplots.
Created cyan/blue-red/yellow color scale similar to coviz.
Make noise filter adjust to current attribute selection.
Make color scale ranges update to current attribute selection.
Introduced uirevision for all plots.
@rnyb rnyb force-pushed the seismic-misfit-improvements branch from c8d5881 to 7480a43 Compare November 12, 2021 08:23
@rnyb rnyb added the next release 🚢 To be included in next release label Nov 12, 2021
@rnyb rnyb merged commit 8b6187a into equinor:master Nov 12, 2021
@rnyb rnyb deleted the seismic-misfit-improvements branch November 12, 2021 09:22
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
* Corrected proptype check for bounds

* Correct bounds props optional check

Co-authored-by: Shadab Khan <Shadab.Khan@Emerson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request next release 🚢 To be included in next release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants