-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seismic misfit improvements #844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-kiaer
requested changes
Nov 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment - otherwise LGTM.
8592dfb
to
c8d5881
Compare
anders-kiaer
approved these changes
Nov 12, 2021
For the polygon, the multi select option is now set to False as it caused issues with combining multiple polygon-files. Also set initial polygon value to empty for slightly better performance at start-up.
Map view layout/zoom persists during callbacks (keep user settings). Map view zoom consistent throughout subplots. Map plot pan works in all directions for subplots.
Created cyan/blue-red/yellow color scale similar to coviz. Make noise filter adjust to current attribute selection. Make color scale ranges update to current attribute selection. Introduced uirevision for all plots.
c8d5881
to
7480a43
Compare
VincentNevermore
pushed a commit
to VincentNevermore/webviz-subsurface
that referenced
this pull request
Jul 19, 2022
* Corrected proptype check for bounds * Correct bounds props optional check Co-authored-by: Shadab Khan <Shadab.Khan@Emerson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements
Contributor checklist
CHANGELOG.md
, and added it if should be communicated there.