Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure slashes and UTF-8 characters stay unescaped #995

Closed
wants to merge 5 commits into from

Conversation

fredden
Copy link

@fredden fredden commented Nov 8, 2022

This pull request ensures that slashes and UTF-8 strings are always unescaped in composer.json. The underlying formatting tool correctly detects if the source file already has escaped slashes and/or escaped UTF-8 characters and produces output to match this. However, as seen in #965, this is not always expected behaviour. This pull request applies an opinionated stance to ensure that formatting remains consistent across projects.

Note that the underlying library that does formatting detection is working correctly.

Fixes #965

Bilge
Bilge previously approved these changes Nov 8, 2022
@localheinz localheinz self-assigned this Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #995 (92f7f15) into main (6efb6bd) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 92f7f15 differs from pull request most recent head ebf183b. Consider uploading reports for the commit ebf183b to get more accurate results

@@             Coverage Diff              @@
##               main     #995      +/-   ##
============================================
+ Coverage     87.04%   87.17%   +0.13%     
  Complexity       57       57              
============================================
  Files             4        4              
  Lines           193      195       +2     
============================================
+ Hits            168      170       +2     
  Misses           25       25              
Impacted Files Coverage Δ
src/Command/NormalizeCommand.php 89.08% <100.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz
Copy link
Member

Closing in favour of #1056.

@localheinz localheinz closed this Feb 26, 2023
@fredden fredden deleted the remove-extra-slashes branch February 27, 2023 10:24
@fredden fredden restored the remove-extra-slashes branch December 5, 2023 12:29
@fredden
Copy link
Author

fredden commented Dec 5, 2023

@localheinz I'm happy to rebase these changes and make them work with the latest version if you'd like. I'll hold off doing that for now though, as GitHub will orphan the branch from this pull request if I force-push while the pull request is closed (and I don't have sufficient permission here to re-open this pull request).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crows feet abuse (unnecessary escaping of slashes)
3 participants