Merge pull request #37 from localheinz/fix/indent

Fix: Reject mixed tabs and spaces as indent
ergebnis · Aug 11, 2018 · 6e11e5c · 6e11e5c
2 parents 74243e7 + d09b305
commit 6e11e5c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Printer.php b/src/Printer.php
@@ -51,7 +51,7 @@ public function print(string $json, string $indent = '    ', string $newLine = \
             ));
         }
 
-        if (1 !== \preg_match('/^[ \t]+$/', $indent)) {
+        if (1 !== \preg_match('/^( +|\t+)$/', $indent)) {
             throw new \InvalidArgumentException(\sprintf(
                 '"%s" is not a valid indent.',
                 $indent

diff --git a/test/Unit/PrinterTest.php b/test/Unit/PrinterTest.php
@@ -73,8 +73,9 @@ public function testPrintRejectsInvalidIndent(string $indent)
     public function providerInvalidIndent(): \Generator
     {
         $values = [
-            'not-whitespace' => $this->faker()->sentence,
-            'contains-line-feed' => " \n ",
+            'string-contains-line-feed' => " \n ",
+            'string-mixed-space-and-tab' => " \t",
+            'string-not-whitespace' => $this->faker()->sentence,
         ];
 
         foreach ($values as $key => $value) {