Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reject mixed tabs and spaces as indent #37

Merged
merged 2 commits into from
Aug 11, 2018
Merged

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Aug 11, 2018

This PR

  • asserts that mixed space and tabs are rejected as indent values
  • adjusts a regular expression

Follows ergebnis/json-normalizer#69.

@localheinz localheinz added the bug label Aug 11, 2018
@localheinz localheinz self-assigned this Aug 11, 2018
@localheinz localheinz changed the title Enhancement: Assert that mix of space and tab is rejected Fix: Reject mixed tabs and spaces as indent Aug 11, 2018
@codecov
Copy link

codecov bot commented Aug 11, 2018

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #37   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       20     20           
=======================================
  Files             1      1           
  Lines            53     53           
=======================================
  Hits             53     53
Impacted Files Coverage Δ Complexity Δ
src/Printer.php 100% <100%> (ø) 20 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74243e7...d09b305. Read the comment docs.

@localheinz localheinz merged commit 6e11e5c into master Aug 11, 2018
@localheinz localheinz deleted the fix/indent branch August 11, 2018 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant