Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrivateInFinalClassRule should not report trait methods #603

Closed
enumag opened this issue Aug 15, 2023 · 3 comments
Closed

PrivateInFinalClassRule should not report trait methods #603

enumag opened this issue Aug 15, 2023 · 3 comments
Assignees
Labels

Comments

@enumag
Copy link
Contributor

enumag commented Aug 15, 2023

Steps required to reproduce the problem

Define a trait with a protected method and a final class using this trait.

Expected Result

No error, methods defined in a trait should be ignored by this rule.

Actual Result

PrivateInFinalClassRule will report this method as that it should be private, however this is only true in the context of that class and may not be true for other usages of the trait.

@localheinz localheinz self-assigned this Aug 15, 2023
@localheinz localheinz added the bug label Aug 15, 2023
@localheinz localheinz changed the title PrivateInFinalClassRule should not report trait methods PrivateInFinalClassRule should not report trait methods Aug 15, 2023
@localheinz localheinz mentioned this issue Jan 23, 2024
1 task
@localheinz
Copy link
Member

Do you still have this issue, @enumag?

I added a test case in #715, but it passes.

@enumag
Copy link
Contributor Author

enumag commented Jan 23, 2024

I no longer work on the project where I encountered it.

@localheinz
Copy link
Member

Thank you, @enumag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants