begin TypeScript conversion #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added notes RE: endpoints that changed from `/scores/` to `/slices/` and now use `scorehash` instead of `slug` #17
… Node should fix `Error: Cannot find module 'fs/promises'`
add question to follow up on about `duplicateSliceByScorehash` and in which folder or subfolder the newly created slice will be created add documentation to `listFolders` about `listSubfoldersByParentId` and how it should be used to list subfolders within a given folder
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins the process of converting this package to TypeScript.
The type definitions aren't comprehensive yet. There are lots of
anyandobjectplaceholders for now.I've also switched from Mocha + Chai to Jest for unit tests, though the unit tests are still superficial. I want to write some proper tests soon.
The code in the
examples/folder is still in vanilla Node.js. These examples import the "built" API client instance from thedist/folder.