From 357e128ec0438ede3e404276188e43f4d0a1d04f Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Mon, 14 Aug 2023 17:13:14 +0000 Subject: [PATCH] Bug 1847114 [wpt PR 41330] - Make dialog user-agent styles apply while in top layer, a=testonly Automatic update from web-platform-tests Make dialog user-agent styles apply while in top layer This makes it so that while the dialog element is doing an exit animation, its positioning etc. styles from the user-agent stylesheet still apply so it doesnt jump to a different spot while animating out. The :modal class is removed during this time which is why it was a problem before. We also can't just make all dialog elements always have these styles applied, because then they would also apply to non-modal dialogs. Spec: https://github.com/whatwg/html/pull/9387 Fixed: 1451910 Change-Id: I4d2b240ab17879d6cf08f94f32d7c7577e9f53ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4739784 Commit-Queue: Joey Arhar Reviewed-by: Mason Freed Cr-Commit-Position: refs/heads/main@{#1179848} -- wpt-commits: d315170388cc39a79899491733317a74d02e19f1 wpt-pr: 41330 --- .../overlay-transition-dialog-ref.html | 6 +++++ .../overlay/overlay-transition-dialog.html | 27 +++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 testing/web-platform/tests/css/css-position/overlay/overlay-transition-dialog-ref.html create mode 100644 testing/web-platform/tests/css/css-position/overlay/overlay-transition-dialog.html diff --git a/testing/web-platform/tests/css/css-position/overlay/overlay-transition-dialog-ref.html b/testing/web-platform/tests/css/css-position/overlay/overlay-transition-dialog-ref.html new file mode 100644 index 0000000000000..b0b8d52e78e9e --- /dev/null +++ b/testing/web-platform/tests/css/css-position/overlay/overlay-transition-dialog-ref.html @@ -0,0 +1,6 @@ + +dialog + diff --git a/testing/web-platform/tests/css/css-position/overlay/overlay-transition-dialog.html b/testing/web-platform/tests/css/css-position/overlay/overlay-transition-dialog.html new file mode 100644 index 0000000000000..0e1297cce75dc --- /dev/null +++ b/testing/web-platform/tests/css/css-position/overlay/overlay-transition-dialog.html @@ -0,0 +1,27 @@ + + + + + + + + +dialog + + + +